Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem when a message is broken into chunks #129

Open
mtmicroclarity opened this issue Mar 16, 2018 · 1 comment
Open

A problem when a message is broken into chunks #129

mtmicroclarity opened this issue Mar 16, 2018 · 1 comment
Milestone

Comments

@mtmicroclarity
Copy link

for (int i=1; i<chunkSequenceNumbers.size(); i++)
if (chunkSequenceNumbers.get(i) != chunkSequenceNumbers.get(i-1)-1) {
String msg = "Sequence numbers of chunks are not consecutive";
log.info(msg);
setError(new ServiceResultException(StatusCodes.Bad_DecodingError, msg));
return;
}

Look closely at "chunkSequenceNumbers.get(i) != chunkSequenceNumbers.get(i-1)-1".

This means if a message is broken into chunks and sequence numbers are 3, 4, 5.
Then it won't pass validation unless sequence numbers are passed as "5,4,3".

@bjakke
Copy link
Contributor

bjakke commented Mar 19, 2018

Thanks for the issue, will be investigated.

Could you please describe the scenario which causes this, e.g. does this happen together with a specific client/server? Can it be reproduced easily? The reason I ask is because the stack has participated directly and indirectly in the IOP Workshops for many years, which should already have minimized these kinds of problems by noticing them early.

P.S. For future issues, please mention the class in question where the code is. (this code is in SecureInputMessageBuilder class).

@bjakke bjakke added this to the 1.4.1 milestone Nov 13, 2018
@bjakke bjakke modified the milestones: 1.4.1, 1.4.2 Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants