-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSTG-NETWORK-1 Added clearText Traffic Info #2037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheDauntless, one first comment before reviewing the content itself. Could you please put all code-like elements in backticks? e.g. android:...
or <application>
.
Why XML elements have a \ preceding them?
See https:/OWASP/owasp-mstg/blob/master/style_guide.md#in-text-keywords
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheDauntless, here are a couple of comments and suggestions. Please take a look :)
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
All comments have been processed. I would prefer to link to a dedicated section on cross-platform frameworks, but since we don't have that one, I'm fine with giving an example for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing :)
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheDauntless 🎉
Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:
If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #2008