Include tests for file enumeration in Calamari file system #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [TestCase(@"Config/Feature1/*.config",new[] {"f1-a.config", "f1-b.config", "f1-c.config"}, 3)] | ||
| [TestCase(@"Config/Feature2/*.config", new[] {"f2.config", "f2-sub.config"}, 2)] | ||
| [TestCase(@"Config/Feature2/Feature2-SubFolder/*.config",new[] {"f2-sub.config"}, 1)] | ||
| public void EnumerateFilesRecursively(string pattern, string[] expectedFilesMatchNameWithRecursion, int expectedQty) |
There was a problem hiding this comment.
I could combine this and the above non-recursive search and pass the file enumeration method as a parameter, but I decided to stick with this primarily for separation and clarity. Let me know if you'd rather them combined.
IsaacCalligeros95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to the Calamari.Physicalfilesystem file enumeration methods. This was changed back to the original functionality in #1164 and there's no explicit test coverage of this functionality. This PR adds some basic test coverage and makes sure that files returned by multiple search patterns are unique.
Test adapter bump is required for running these locally for net461 - see OctopusDeploy/Halibut#223