Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMaps API language (Streetnames) #33

Open
nvirm opened this issue Jun 26, 2015 · 5 comments
Open

GMaps API language (Streetnames) #33

nvirm opened this issue Jun 26, 2015 · 5 comments

Comments

@nvirm
Copy link

nvirm commented Jun 26, 2015

Hello! The plugin seems to work flawlessly in general. However, some of the streetnames are being shown on my country's second language, some are shown right. Could it be possible to update the .APK to include language choosing (fi-FI, en-EN etc.) 👍 ?

@Oitzu
Copy link
Owner

Oitzu commented Jul 2, 2015

Hi! The street-names are actually gathered by the plugin itself with the use of the google maps api.
Are the streetnames you are talking about displayed correctly on google maps?
I don't know if and how google maps supports multiple languages on streetnames.

@nvirm
Copy link
Author

nvirm commented Aug 27, 2015

Sorry for the responsetiming! I have tried to fix the issue by myself (hobbying :)..), but with little results.

Unlike I first thought, the address resolving comes from the pimatic plugin, not the Android APK, I think..?

Links:
https://developers.google.com/maps/faq?utm_source=welovemapsdevelopers&utm_campaign=mdr-launch#languagesupport
https://developers.google.com/maps/documentation/geocoding/intro#Results

Optional parameters in a geocoding request:
language — The language in which to return results. See the list of supported domain languages. Note that we often update supported languages so this list may not be exhaustive. If language is not supplied, the geocoder will attempt to use the native language of the domain from which the request is sent wherever possible.

The issue for me (I suppose any two-language countries have the same issue) is that the streetnames are chosen (seemingly) randomly from the two available languages.

if this gets resolved, perhaps adding a "language": "en-GB" part to config wouldn't hurt I suppose? the user could then easily select the language for himself from https://developers.google.com/maps/faq#languagesupport

@nvirm
Copy link
Author

nvirm commented Aug 27, 2015

https://www.npmjs.com/package/googlemapsutil Is the library referenced in the plugin I suppose.

There seem to be mentions of language in the files, but so far I haven't been able to patch it to being functional in the plugin. :(

@nvirm
Copy link
Author

nvirm commented Sep 1, 2015

Fixed by adding + "&language=fi" to googlemapsutil js file. :) ..
However if it were a variable in config, it would be more user accessible.

@nvirm nvirm closed this as completed Sep 1, 2015
@Oitzu Oitzu reopened this Sep 1, 2015
@Oitzu
Copy link
Owner

Oitzu commented Sep 1, 2015

Do you maybe feel safe enough to do pull request on corresponding repositories?
The googlemapsutil.js is in this repository: https:/Oitzu/googleMapsUtil
The pimatic plugin is here: https:/Oitzu/pimatic-location-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants