Ava Upgrade #654
Merged
Ava Upgrade #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated travis file to match
rgomezp
commented
Jun 16, 2020
|
|
||
| export function beforeEach<T>(getContext: () => Promise<T>): RegisterContextual<T> { |
There was a problem hiding this comment.
Not sure what RegisterContextual is/is doing. It was deprecated and no longer exists in
rgomezp
commented
Jun 16, 2020
|
To update |
itrush
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Reviewed 15 of 30 files at r1, 15 of 15 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jkasten2 and @rgomezp)
test/unit/helpers/ServiceWorkerHelper.ts, line 36 at r2 (raw file):
test.todo("upsertSession: if has existing session, reactivate if inactive");
may I ask you please to create a jira ticket to implement these tests? I thought I already did but apparently it's not true. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades Ava testing framework for better testing of the WebSDK + compatibility with VSCode debugging support.
Changes
^0.21.0to^2.8.2TestContextandContextno longer exported by Ava npm packaget.throwsmethod signature changedt.throwsAsyncnow required for asynchronous functionsValidation:
[x ] All the automated tests pass or I explained why that is not possible
[x] I have personally tested this on my machine or explained why that is not possible
This change is