Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable time of day changes from blue warps #2235

Open
fenhl opened this issue May 31, 2024 · 0 comments · May be fixed by #2304
Open

Repeatable time of day changes from blue warps #2235

fenhl opened this issue May 31, 2024 · 0 comments · May be fixed by #2304
Labels
Component: Algorithm Search, Fill, Playthrough, etc Component: ASM/C Changes some internals of the ASM/C libraries Type: Bug Something isn't working

Comments

@fenhl
Copy link
Collaborator

fenhl commented May 31, 2024

As previously discussed at #2034 (comment) and #2034 (comment), taking a blue warp for the first time is one of the few remaining instances of nonrepeatable time-of-day access, which can lead to nonrepeatable entrance access, which can in turn lead to softlocks due to the way the logic for the Spirit temple is written. There are two ways to address this:

  1. Remove the ToD changes from blue warps entirely
  2. Make them repeatable, i.e. set ToD every time a blue warp is taken and not just the first time

Removing the ToD changes is very easy now that they've been reimplemented in rando code, but it has the disadvantage of more significant gameplay impact, as there is very rarely any reason to take a given blue warp more than once, and some players use the ToD changes as part of their routing. Repeatability also makes a potential future blue warp ER setting a bit more unique rather than just adding 8 shuffled entrances that behave like owls. Therefore, I think this is the best way to address this bug.

Complications include: We have to hack the blue warps to apply the ToD change on every instance of one being taken (help wanted here), and we have to write the logic for it (see the logic for handling outside Ganon's Castle for reference).

@fenhl fenhl added Type: Bug Something isn't working Status: Help Wanted Extra attention is needed Component: Algorithm Search, Fill, Playthrough, etc Component: ASM/C Changes some internals of the ASM/C libraries labels May 31, 2024
@fenhl fenhl removed the Status: Help Wanted Extra attention is needed label Aug 26, 2024
@fenhl fenhl modified the milestone: next Sep 8, 2024
@fenhl fenhl linked a pull request Sep 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Algorithm Search, Fill, Playthrough, etc Component: ASM/C Changes some internals of the ASM/C libraries Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant