Remove references to “sanity” in setting display names

[fenhl]

As discussed today in #rsl-discussion, these names can be confusing for newcomers, since the “in-” prefix is truncated. I have replaced them with more descriptive names:

• “Shopsanity” becomes “Shuffle Shops”
• “Shopsanity Prices” becomes “Special Deal Prices”
• “Tokensanity” becomes “Shuffle Gold Skulltula Tokens”

While I was in there, I also updated some outdated code comments and removed a commented-out block of code.

An open question is whether the internal names should be changed as well.

[cjohnson57]

Definitely not worth changing the internal names.

I question if this is necessary, I don't think it's hard to glean the meaning. My first time looking at the rando I understood "Oh, tokensanity, that means tokens but insane or something, oh I see it controls how they're shuffled, makes sense"

[ETR-BTF]

I think it would be good to change the internal names that are printed in the spoiler log to be consistent with the names of the settings. The keysanity options are also inconsistently named, where "Remove (Keysey)" is called remove but Anywhere (Keysanity) is called keysanity.

This would break plandos, so if internal names get changed it might be best to merge this right before a new release.

Edit:

I question if this is necessary, I don't think it's hard to glean the meaning. My first time looking at the rando I understood "Oh, tokensanity, that means tokens but insane or something, oh I see it controls how they're shuffled, makes sense"

Descriptive settings names would make it easier for new users to parse the GUI.

[fenhl]

In the discussion in #rsl-discussion, some people (myself included) mentioned that they were initially confused when they were new to the randomizer, thinking that “sanity” would imply less randomization, not more. As a neat bonus, this avoids the possible interpretation of implying negative things about setting preferences (“you're insane if you use this setting”).

[ETR-BTF]

I've also always found it strange that they were called "sanities" when they introduce chaos into your seed. "mania" might be a less ambiguous suffix, but I personally prefer names that are clear and descriptive.

[ETR-BTF]

This would break plandos, so if internal names get changed it might be best to merge this right before a new release.

And it would break the website too.

[cjohnson57]

I'm going to be closing this as I don't agree with the change, but maybe the idea can be revisited at some point.

[fenhl]

I would like to ask you to reconsider. There are 3 clear advantages to this change:

1. Removing confusion due to the missing “in-” prefix, which has already been discussed above
2. Clarifying that “Special Deal Prices” only apply to special deals, not regular shop items
3. Avoiding usage of a mental health term in a negative way

That third point has barely been mentioned in this thread, and I'm bad at explaining this sort of thing, so I asked Melrose to elaborate. Posting with his permission:

Right now on Twitter there's discourse about people with visual impairments being upset with streamers/content creators using the term "blind" to describe their first playthrough. Of course when someone new is exposed to the title of "New game [blind playthrough]" there might be an awkward moment where the viewer is wondering why the content creator isn't actually visually impaired but has the terminology of blind playthrough in their title. Over time the majority of people have come to accept "blind playthrough" meaning first playthrough, but that doesn't eliminate the fact that some people are going misinterpret blind playthrough as literal and the fact still exists that some people with visual impairment (as well as friends and family) get upset that the term "blind" is personal to them and it's being used trivially to describe something that can easily be avoided if people made the effort to use "first playthrough" instead of "blind playthrough". The parallel with the sanity suffix in randomisers should be prevalent, we have accurate terminology that bypasses any confusion someone might initially get with sanity being used as a suffix, plus insanity is a life altering mental illness that severely affects the patient and the friends and families of that person but it's being used trivially without a care. The solution is straightforward and rewards more than it recedes, people in charge of these naming conventions need to recognise that they can do better and they should be doing better.

I guess I should also emphasise that it's severely overlooked because we don't recognise insanity as a derogatory term (same with blind, you can use these terms as insults but they aren't universally considered worthy of censorship) but that doesn't mean it doesn't connote sensitive triggers to anyone coping with or knows someone coping with mental health illnesses.