Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HF Deku Scrub Location Hint Text #2281

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from
Open

Update HF Deku Scrub Location Hint Text #2281

wants to merge 2 commits into from

Conversation

Natheirean
Copy link

Changed hint text from single upgrade deku scrub to lonely deku scrub. In vanilla, this scrub sells a piece of heart, not an item upgrade

@fenhl fenhl added Type: Enhancement New feature or request Component: Hints related to how we help the player Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described Racing Impact Changes a mechanic in a way that impacts the balance of competitive racing. labels Aug 12, 2024
fenhl
fenhl requested changes Aug 12, 2024
View reviewed changes
HintList.py Outdated Show resolved Hide resolved
@fenhl fenhl added Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it labels Aug 12, 2024
@cjohnson57
Copy link
Collaborator

Makes sense to me

@fenhl
Copy link
Collaborator

fenhl commented Aug 12, 2024 •
edited
Loading

I believe “Upgrade” was used here in the sense of “nonrepeatable item check” aka “relevant without scrub shuffle”. The wording proposed in this PR is less ambiguous though as discussed in #dev-suggestions.

@Natheirean @fenhl
Update HintList.py
8817773 
casing fix

Co-authored-by: Fenhl <[email protected]>
@fenhl fenhl removed Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it labels Aug 12, 2024
@fenhl fenhl removed the Status: Needs Testing Probably should be tested label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenhl fenhl fenhl approved these changes

Assignees
No one assigned
Labels
Component: Hints related to how we help the player Racing Impact Changes a mechanic in a way that impacts the balance of competitive racing. Status: Under Consideration Developers are considering whether to accept or decline the feature described Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Natheirean @cjohnson57 @fenhl