Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error handling #248

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: Error handling #248

merged 1 commit into from
Jun 20, 2024

Conversation

soumeh01
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Test Results

  4 files  ±0   48 suites  ±0   5s ⏱️ ±0s
200 tests  - 1  200 ✅  - 1  0 💤 ±0  0 ❌ ±0 
800 runs   - 4  800 ✅  - 4  0 💤 ±0  0 ❌ ±0 

Results for commit ee4bdd4. ± Comparison against base commit 1aba21b.

This pull request removes 1 test.
github.com/Open-CMSIS-Pack/cbuild/v2/pkg/builder/csolution ‑ TestGetCbuildSetFilePath/test_invalid_input_file

♻️ This comment has been updated with latest results.

@soumeh01 soumeh01 requested a review from brondani June 19, 2024 17:47
@soumeh01 soumeh01 force-pushed the logMsg branch 4 times, most recently from 2a79270 to 876ff68 Compare June 20, 2024 06:42
@soumeh01 soumeh01 changed the title Log error msgs fix: Log error messages on errors Jun 20, 2024
Copy link

codeclimate bot commented Jun 20, 2024

Code Climate has analyzed commit ee4bdd4 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 53.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.5% (-1.0% change).

View more on Code Climate.

@soumeh01 soumeh01 changed the title fix: Log error messages on errors fix: Error handling Jun 20, 2024
@soumeh01 soumeh01 merged commit c0712bd into main Jun 20, 2024
14 of 16 checks passed
@soumeh01 soumeh01 deleted the logMsg branch June 20, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants