lib: Remove warnings from -Wcast-align #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnopo
reviewed
May 12, 2022
There were several places in the library where a char* was used to point to a wider type (uint32_t or a struct). Casting the char* to the wider type resulted in a compiler warning. This commit changes some simple casts to (void *) to silence compiler warnings. In rsc_table_parser.c, replace casts and pointer arithmetic with explicit uses of fw_rsc_hdr. Signed-off-by: Ed Mooring <[email protected]>
arnopo
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several places in the library where a char* was used to point
to a wider type (uint32_t or a struct). Casting the char* to the wider
type resulted in a compiler warning.
This commit adds a cast to void* to remove the compiler warnings. This
results in no functional change.
Signed-off-by: Ed Mooring [email protected]