remoteproc: Un-inline remoteproc_init_mem() and remoteproc_add_mem() #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having these functions as inline header functions forces the contents of struct remoteproc_mem to remain externally exposed. It also does not save space in most cases as every call-site gets the full contents of the function instead of just a call instruction. Make these normal functions like all others in remoteproc.h. Signed-off-by: Andrew Davis <[email protected]>
arnopo
approved these changes
Mar 29, 2024
xiaoxiang781216
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having these functions as inline header functions forces the contents of struct remoteproc_mem to remain externally exposed. It also does not save space in most cases as every call-site gets the full contents of the function instead of just a call instruction. Make these normal functions like all others in remoteproc.h.