-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gradle] Reworking publishing pipeline #2886
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ea12ed0
[gradle] Reworking publishing pipeline
jimschubert 6b0c3fa
Change the 'publish' task to 'publishToMavenLocal' in the helper pom.xml
jmini becc3b2
Add condition on signing and be explicit about sources/javadoc artifacts
jimschubert a8d4ec0
Call close/closeAndReleaseRepository
jimschubert 59c0ea1
Reuse same closeAndReleaseRepository for SNAPSHOT + releases using a …
jimschubert 9049b2a
Add v prefix for tag check.
jimschubert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
buildscript { | ||
ext.kotlin_version = '1.2.60' | ||
ext.kotlin_version = '1.2.61' | ||
repositories { | ||
mavenCentral() | ||
maven { | ||
|
@@ -11,14 +11,13 @@ buildscript { | |
maven { | ||
url "https://oss.sonatype.org/content/repositories/snapshots/" | ||
} | ||
maven { | ||
url "https://plugins.gradle.org/m2/" | ||
} | ||
} | ||
dependencies { | ||
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" | ||
classpath "gradle.plugin.org.gradle.kotlin:gradle-kotlin-dsl-plugins:1.0-rc-3" | ||
classpath "com.gradle.publish:plugin-publish-plugin:0.10.1" | ||
classpath "io.codearte.gradle.nexus:gradle-nexus-staging-plugin:0.20.0" | ||
classpath "de.marcphilipp.gradle:nexus-publish-plugin:0.2.0" | ||
} | ||
} | ||
|
||
|
@@ -35,10 +34,11 @@ ext.isReleaseVersion = !version.endsWith("SNAPSHOT") | |
|
||
apply plugin: 'com.gradle.plugin-publish' | ||
apply plugin: 'java-gradle-plugin' | ||
apply plugin: 'maven' | ||
apply plugin: 'signing' | ||
apply plugin: 'kotlin' | ||
apply plugin: "org.gradle.kotlin.kotlin-dsl" | ||
apply plugin: 'io.codearte.nexus-staging' | ||
apply plugin: "de.marcphilipp.nexus-publish" | ||
|
||
sourceCompatibility = 1.8 | ||
targetCompatibility = 1.8 | ||
|
@@ -87,6 +87,65 @@ test { | |
} | ||
} | ||
|
||
task javadocJar(type: Jar) { | ||
from javadoc | ||
classifier = 'javadoc' | ||
} | ||
|
||
task sourcesJar(type: Jar) { | ||
from sourceSets.main.allSource | ||
classifier = 'sources' | ||
} | ||
|
||
publishing { | ||
publications { | ||
mavenJava(MavenPublication) { | ||
from components.java | ||
artifact sourcesJar | ||
artifact javadocJar | ||
pom { | ||
name = 'OpenAPI-Generator Contributors' | ||
description = project.description | ||
url = 'https://openapi-generator.tech' | ||
organization { | ||
name = 'org.openapitools' | ||
url = 'https:/OpenAPITools' | ||
} | ||
licenses { | ||
license { | ||
name = "The Apache Software License, Version 2.0" | ||
url = "http://www.apache.org/licenses/LICENSE-2.0.txt" | ||
distribution = "repo" | ||
} | ||
} | ||
developers { | ||
developer { | ||
id = "openapitools" | ||
name = "OpenAPI-Generator Contributors" | ||
email = "[email protected]" | ||
} | ||
} | ||
scm { | ||
url = 'https:/OpenAPITools/openapi-generator' | ||
connection = 'scm:git:git:/OpenAPITools/openapi-generator.git' | ||
developerConnection = 'scm:git:ssh://[email protected]:OpenAPITools/openapi-generator.git' | ||
} | ||
issueManagement { | ||
system = 'GitHub' | ||
url = 'https:/OpenAPITools/openapi-generator/issues' | ||
} | ||
} | ||
} | ||
} | ||
} | ||
|
||
nexusPublishing { | ||
username = ossrhUsername | ||
password = ossrhPassword | ||
stagingProfileId = "org.openapitools" | ||
packageGroup = "org.openapitools" | ||
} | ||
|
||
gradlePlugin { | ||
plugins { | ||
openApiGenerator { | ||
|
@@ -109,6 +168,7 @@ pluginBundle { | |
displayName = 'OpenAPI Generator Gradle Plugin' | ||
tags = ['openapi-3.0', 'openapi-2.0', 'openapi', 'swagger', 'codegen', 'sdk'] | ||
version = "$openApiGeneratorVersion" | ||
group = "org.openapitools" | ||
} | ||
} | ||
} | ||
|
@@ -119,79 +179,8 @@ pluginBundle { | |
// or stored as key=value pairs in ~/.gradle/gradle.properties | ||
// You can also apply them in CI via environment variables. See Gradle's docs for details. | ||
signing { | ||
required { isReleaseVersion && gradle.taskGraph.hasTask("uploadArchives") } | ||
sign configurations.archives | ||
} | ||
|
||
task javadocJar(type: Jar) { | ||
classifier = 'javadoc' | ||
from javadoc | ||
} | ||
|
||
task sourcesJar(type: Jar) { | ||
from sourceSets.main.allSource | ||
classifier = 'sources' | ||
} | ||
|
||
artifacts { | ||
archives javadocJar, sourcesJar | ||
} | ||
|
||
def pomConfig = { | ||
description project.description | ||
name 'OpenAPI-Generator Contributors' | ||
url 'https://openapi-generator.tech' | ||
organization { | ||
name 'org.openapitools' | ||
url 'https:/OpenAPITools' | ||
} | ||
licenses { | ||
license { | ||
name "The Apache Software License, Version 2.0" | ||
url "http://www.apache.org/licenses/LICENSE-2.0.txt" | ||
distribution "repo" | ||
} | ||
} | ||
developers { | ||
developer { | ||
id "openapitools" | ||
name "OpenAPI-Generator Contributors" | ||
email "[email protected]" | ||
} | ||
} | ||
scm { | ||
url 'https:/OpenAPITools/openapi-generator' | ||
connection 'scm:git:git:/OpenAPITools/openapi-generator.git' | ||
developerConnection 'scm:git:ssh://[email protected]:OpenAPITools/openapi-generator.git' | ||
} | ||
issueManagement { | ||
system 'GitHub' | ||
url 'https:/OpenAPITools/openapi-generator/issues' | ||
} | ||
} | ||
|
||
uploadArchives { | ||
repositories { | ||
|
||
// credentials here would need to be passed along with the gradle command: | ||
// ./gradlew -P ossrhUsername=yourUser | ||
// or stored in ~/.gradle/gradle.properties as key=value pairs | ||
mavenDeployer { | ||
beforeDeployment { MavenDeployment deployment -> signing.signPom(deployment) } | ||
repository(url: "https://oss.sonatype.org/service/local/staging/deploy/maven2/") { | ||
authentication(userName: ossrhUsername, password: ossrhPassword) | ||
} | ||
snapshotRepository(url: "https://oss.sonatype.org/content/repositories/snapshots/") { | ||
authentication(userName: ossrhUsername, password: ossrhPassword) | ||
} | ||
|
||
pom.withXml { | ||
def root = asNode() | ||
root.appendNode('description', project.description) | ||
root.children().last() + pomConfig | ||
} | ||
} | ||
} | ||
required { isReleaseVersion && (gradle.taskGraph.hasTask("publishPluginMavenPublicationToNexusRepository") ) } | ||
sign publishing.publications.mavenJava | ||
} | ||
|
||
compileKotlin { | ||
|
@@ -205,4 +194,19 @@ compileTestKotlin { | |
} | ||
} | ||
|
||
uploadArchives.dependsOn 'check' | ||
javadoc { | ||
if(JavaVersion.current().isJava9Compatible()) { | ||
options.addBooleanOption('html5', true) | ||
} | ||
} | ||
|
||
tasks { | ||
closeRepository { | ||
onlyIf { nexusPublishing.useStaging.get() } | ||
} | ||
releaseRepository{ | ||
onlyIf { nexusPublishing.useStaging.get() } | ||
} | ||
} | ||
|
||
publishToNexus.dependsOn 'check' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
rootProject.name = 'openapi-generator-gradle-plugin' | ||
enableFeaturePreview('STABLE_PUBLISHING') | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the 4.0.1 release fails, we may consider reverting to the
uploadArchives
andmaven
publishing plugin.