-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-axios] switched to new URL API #6960
[typescript-axios] switched to new URL API #6960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for your contribution |
@macjohnny |
Thanks for the update |
This PR introduces a bug that |
@breeswish this could be fixed by renaming Lines 111 to 116 in 6909c88
would you like to fix this? |
I have made a PR #7475. |
Hi, it seems the above PR #7475 is not contained in the latest 5.0.0-beta2: https:/OpenAPITools/openapi-generator/blob/v5.0.0-beta2/modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache#L191 |
The latest version is 5.0.0 and that PR is included in 5.0.0 or 5.0.0-beta.3. |
ok, thanks! let me try it later. |
hi @sapphi-red , sorry I didn't find the responding version in the https://www.npmjs.com/package/@openapitools/openapi-generator-cli , did version 5.0.0 and 5.0.0-beta.3 release to npm, or I should install 2.1.16? My current version is "^1.0.15-4.3.1". After running "@openapitools/openapi-generator-cli@^1.0.15-4.3.1":
- version "1.0.15-4.3.1"
- resolved "https://registry.yarnpkg.com/@openapitools/openapi-generator-cli/-/openapi-generator-cli-1.0.15-4.3.1.tgz#25ef943eba3c82e82379b30f858bb05ed97dae0b"
- integrity sha512-U+sanspDmeBElVNjYHQ4U7BbSEJUQzjNKmiTzXpcEw/r93sgxmzS2Sew5t+Zj6kyN1YTvjhRjJikNcW9/bmTKA==
+ version "1.0.15-5.0.0-beta"
+ resolved "https://registry.yarnpkg.com/@openapitools/openapi-generator-cli/-/openapi-generator-cli-1.0.15-5.0.0-beta.tgz#01b4805308d10762655158f446ebc54032ca33cc"
+ integrity sha512-4Sbl/o2XbArryKnvsAtrK4UwXe0nTGnHErkYlMuIZYWBIZdEq8EeHHHHcVLlH1K3LZVP+uu18If51DcLtqVW4A== |
@baurine You need to install |
hi @sapphi-red , it works after upgrading to 2.1.16, thank you! I just a little didn't understand, the old version just depends on ONE npm package while the new version depends on a ton of npm packages (likes nestjs, nuxtjs ...), isn't it just a wrapper of the jar? why does it need other npm packages? |
I do not know about that, maybe creating an issue at the repository below would be better. |
As part of this upgrade I had to update the Swagger template to avoid trying to delete a non-optional property. I referenced this PR: OpenAPITools/openapi-generator#6960
Switched to new URL API since Node.js legacy URL API is deprecated.
This will drop support Node.js below v6.0.0 (which was released Apr. 2016).
close #6859
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH.master
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)