Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

全量同步CopyRemoteMeta，如果重试多次，resp->code() 均不等于 RsyncService::kOk，那么应该设置一个错误的 Status 返回。默认的Status被认为是一个正常状态，即kOk。 #2299

Closed
chengyu-l opened this issue Jan 12, 2024 · 0 comments
Closed

全量同步CopyRemoteMeta，如果重试多次，resp->code() 均不等于 RsyncService::kOk，那么应该设置一个错误的 Status 返回。默认的Status被认为是一个正常状态，即kOk。 #2299

chengyu-l opened this issue Jan 12, 2024 · 0 comments
Labels
☢️ Bug Something isn't working

Comments

@chengyu-l
Copy link
Contributor

Is this a regression?

Yes

Description

全量同步CopyRemoteMeta，如果重试多次，resp->code() 均不等于 RsyncService::kOk，那么应该设置一个错误的 Status 返回。默认的Status被认为是一个正常状态，即kOk。

image

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response
@chengyu-l chengyu-l added the ☢️ Bug Something isn't working label Jan 12, 2024
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 13, 2024
fix: if resp->code() != RsyncService::kOk should set SyncSlaveSlot re…
fe917f7 
…pl_state_ to kError(OpenAtomFoundation#2299)
@chengyu-l chengyu-l mentioned this issue Jan 13, 2024
Merged
AlexStocks pushed a commit that referenced this issue Jan 13, 2024
@chengyu-l
fix: if resp->code() != RsyncService::kOk should set SyncSlaveSlot re…
349f97a 
…pl_state_ to kError(#2299) (#2315)

Co-authored-by: liuchengyu <[email protected]>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this issue Jun 8, 2024
@chengyu-l
fix: if resp->code() != RsyncService::kOk should set SyncSlaveSlot re…
2540251 
…pl_state_ to kError(OpenAtomFoundation#2299) (OpenAtomFoundation#2315)

Co-authored-by: liuchengyu <[email protected]>
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
@chengyu-l
fix: if resp->code() != RsyncService::kOk should set SyncSlaveSlot re…
b357ee4 
…pl_state_ to kError(OpenAtomFoundation#2299) (OpenAtomFoundation#2315)

Co-authored-by: liuchengyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chengyu-l