Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【优化建议】如果localFileMap为空，就不需要再执行 UpdateLocalMeta函数 #2303

Closed
chengyu-l opened this issue Jan 12, 2024 · 0 comments
Closed

【优化建议】如果localFileMap为空，就不需要再执行 UpdateLocalMeta函数 #2303

chengyu-l opened this issue Jan 12, 2024 · 0 comments
Labels
☢️ Bug Something isn't working

Comments

@chengyu-l
Copy link
Contributor

Is this a regression?

Yes

Description

【优化建议】如果file_set_（remote_file_set）为空，就不需要再执行 UpdateLocalMeta函数。UpdateLocalMeta函数内部没有判断localFileMap为空的情况，无论是否为空，都会打开文件，然后关闭文件。

image

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response
@chengyu-l chengyu-l added the ☢️ Bug Something isn't working label Jan 12, 2024
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 13, 2024
fix: If the localFileMap is empty, do not continue execution(OpenAtom…
98b3e71 
…Foundation#2303)
AlexStocks pushed a commit that referenced this issue Jan 13, 2024
@chengyu-l
fix: If the localFileMap is empty, do not continue execution(#2303) (#…
2e3dc74 
…2312)

Co-authored-by: liuchengyu <[email protected]>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this issue Jun 8, 2024
@chengyu-l
fix: If the localFileMap is empty, do not continue execution(OpenAtom…
273651d 
…Foundation#2303) (OpenAtomFoundation#2312)

Co-authored-by: liuchengyu <[email protected]>
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
@chengyu-l
fix: If the localFileMap is empty, do not continue execution(OpenAtom…
566db7c 
…Foundation#2303) (OpenAtomFoundation#2312)

Co-authored-by: liuchengyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chengyu-l