Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete hashkey and hincrby twice, first get wrong answer and next get coredump #2885

Closed
wanghenshui opened this issue Aug 29, 2024 · 6 comments
Assignees
Labels
☢️ Bug Something isn't working

Comments

@wanghenshui
Copy link
Collaborator

wanghenshui commented Aug 29, 2024

Is this a regression?

No

Description and minimal reproduction of the bug

pika 4.0.0
repro

hincrby h 112000005 1000
hgetall h
del h
hincrby h 112000005 1000
hgetall h # already bug here
hincrby h 112000005 1000 # coredump

source code

    Int64ToStr(value_buf, 32, value);
    BaseDataValue internal_value(value_buf);
    batch.Put(handles_[kHashesDataCF], hashes_data_key.Encode(), internal_value.Encode());

Int64ToStr modified value_buf, value_buf implict convert to Slice, maybe bug here

Please provide the version you discovered this bug in (check about page for version information)

pika 4.0.0
@wanghenshui wanghenshui added the ☢️ Bug Something isn't working label Aug 29, 2024
@wanghenshui wanghenshui changed the title pika 4.0 hincrby bug delete hashkey and hincrby twice, first get wrong answer and next get coredump Aug 29, 2024
@QlQlqiqi
Copy link
Contributor

用 unstable 分支的最新代码(4bfb5e788a1a6fd92dff20d5f1fa24e26ee3d128)测了一下,没有发现问题
cf6b77fbafe87110211867e12c86ba7

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I tested it with the latest code from the unstable branch (4bfb5e7) and found no problem.
cf6b77fbafe87110211867e12c86ba7

@QlQlqiqi
Copy link
Contributor

我认为这个 issue 和 #2835 类似,不知是否是同一原因

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I think this issue is similar to #2835, I don’t know if it’s the same reason

@wanghenshui
Copy link
Collaborator Author

我认为这个 issue 和 #2835 类似,不知是否是同一原因

确实是同一个问题,建议backport

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I think this issue is similar to #2835, I wonder if it is the same reason

It's indeed the same problem, I suggest you backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️ Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants