fix: refactor pstd_mutex #1440
Merged
fix: refactor pstd_mutex #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
May 6, 2023
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| class PikaAuxiliaryThread : public net::Thread { | |||
| public: | |||
| PikaAuxiliaryThread() : mu_(), cv_(&mu_) { set_thread_name("AuxiliaryThread"); } | |||
| PikaAuxiliaryThread() { set_thread_name("AuxiliaryThread"); } | |||
There was a problem hiding this comment.
pstd::Mutex 和 pstd::ConVar都改了
There was a problem hiding this comment.
using Mutex = std::mutex;
using CondVar = std::condition_variable;用标准库的默认构造就行
There was a problem hiding this comment.
不太清楚这里为啥没换成标准库实现。
哪里没换
4kangjc
force-pushed
the
pstd-support-windows
branch
from
6244afb
to
b465c2f
Compare
AlexStocks
reviewed
May 6, 2023
AlexStocks
reviewed
May 6, 2023
AlexStocks
reviewed
May 6, 2023
AlexStocks
reviewed
May 6, 2023
AlexStocks
reviewed
May 6, 2023
loveyacper
reviewed
May 7, 2023
loveyacper
reviewed
May 7, 2023
4kangjc
force-pushed
the
pstd-support-windows
branch
4 times, most recently
from
ab9bf3c
to
965fde2
Compare
4kangjc
commented
May 8, 2023
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| class PikaAuxiliaryThread : public net::Thread { | |||
| public: | |||
| PikaAuxiliaryThread() : mu_(), cv_(&mu_) { set_thread_name("AuxiliaryThread"); } | |||
| PikaAuxiliaryThread() { set_thread_name("AuxiliaryThread"); } | |||
There was a problem hiding this comment.
pstd::Mutex 和 pstd::ConVar都改了
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| class PikaAuxiliaryThread : public net::Thread { | |||
| public: | |||
| PikaAuxiliaryThread() : mu_(), cv_(&mu_) { set_thread_name("AuxiliaryThread"); } | |||
| PikaAuxiliaryThread() { set_thread_name("AuxiliaryThread"); } | |||
There was a problem hiding this comment.
using Mutex = std::mutex;
using CondVar = std::condition_variable;用标准库的默认构造就行
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| class PikaAuxiliaryThread : public net::Thread { | |||
| public: | |||
| PikaAuxiliaryThread() : mu_(), cv_(&mu_) { set_thread_name("AuxiliaryThread"); } | |||
| PikaAuxiliaryThread() { set_thread_name("AuxiliaryThread"); } | |||
There was a problem hiding this comment.
不太清楚这里为啥没换成标准库实现。
哪里没换
| version_->term_ = term; | ||
| version_->StableSave(); | ||
| } | ||
|
|
||
| uint32_t term() { | ||
| pstd::RWLock(&(version_->rwlock_), true); |
| last_meta_sync_timestamp_ = time(nullptr); | ||
| } | ||
|
|
||
| bool PikaServer::IsFirstMetaSync() { | ||
| pstd::RWLock sp_l(&state_protector_, true); |
AlexStocks
approved these changes
May 8, 2023
AlexStocks
reviewed
May 9, 2023
AlexStocks
reviewed
May 9, 2023
AlexStocks
reviewed
May 9, 2023
AlexStocks
reviewed
May 9, 2023
4kangjc
force-pushed
the
pstd-support-windows
branch
from
965fde2
to
b8f8396
Compare
…e and std::shared_mutex
4kangjc
force-pushed
the
pstd-support-windows
branch
from
b8f8396
to
e3286c3
Compare
luky116
approved these changes
May 10, 2023
ForestLH
pushed a commit
to ForestLH/pika
that referenced
this pull request
May 10, 2023
* Remove pstd::cond_lock * refactor: Refactor pstd_mutex with std::mutex, std::condition_variable and std::shared_mutex
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* Remove pstd::cond_lock * refactor: Refactor pstd_mutex with std::mutex, std::condition_variable and std::shared_mutex
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* Remove pstd::cond_lock * refactor: Refactor pstd_mutex with std::mutex, std::condition_variable and std::shared_mutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.