Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete_sharding_command cluster_info&&slot_command #1481

Merged
merged 1 commit into from
May 12, 2023
Merged

delete_sharding_command cluster_info&&slot_command #1481

merged 1 commit into from
May 12, 2023

Conversation

chejinge
Copy link
Collaborator

No description provided.

@@ -190,24 +190,6 @@ const std::string kCmdNamePubSub = "pubsub";
const std::string kCmdNamePSubscribe = "psubscribe";
const std::string kCmdNamePUnSubscribe = "punsubscribe";

// Codis Slots

This comment was marked as resolved.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

具体是指的codis干啥用的, 我理解主从复制模式只有一个slot,根本不需要这些命令。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有主从复制为什么要适配codis,主从复制我理解不需要codis

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有主从复制为什么要适配codis,主从复制我理解不需要codis

是做“分布式”,并非做主从复制

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有主从复制为什么要适配codis,主从复制我理解不需要codis

是做“分布式”,并非做主从复制

我看了一下这个命令的复用性不是很大,大概率要重新设计适配codis

@chejinge chejinge closed this May 11, 2023
@chejinge chejinge reopened this May 11, 2023
@chejinge chejinge merged commit 5696b16 into OpenAtomFoundation:unstable May 12, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants