Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#1597: add rocksdb dependency to pstd #1599

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

A2ureStone
Copy link
Contributor

pstd使用了rocksdb/slice.h里面的纯头文件的类, 但是pstd里的CmakeLists.txt没有对rocksdb的依赖, 导致在rocksdb没下载的情况下开始编译pstd
#1597

@A2ureStone
Copy link
Contributor Author

A2ureStone commented Jun 7, 2023

新加了cstdint是因为原来这些头文件里使用了uint32_t的类型而没有直接引用cstdint, 这是原来include的头文件间接引入了这些类型, 最新版的gcc15移除了这些间接引入, 编译会不通过

@AlexStocks AlexStocks merged commit dc8678f into OpenAtomFoundation:unstable Jun 7, 2023
lqxhub pushed a commit to lqxhub/pika that referenced this pull request Jun 18, 2023
* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>
lqxhub pushed a commit to lqxhub/pika that referenced this pull request Jul 2, 2023
* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>
AlexStocks added a commit that referenced this pull request Jul 2, 2023
* feat: supported 'ptype' command

* Simplified command `type` and `ptype` code

* Remove the capacity judgment

* fix slavaof serialize response bug (#1583)

Co-authored-by: liuyuecai <[email protected]>

* fix (#1587) (#1588)

* fix unit test:type/set (#1577)

* Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (#1590)

* fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg).

* add address/thread sanitizer to CMakeLists

---------

Co-authored-by: cjh <[email protected]>

* refactor: replace pstd/env with std::filesystem (#1470)

* fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (#1595)

using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly

* fix: incorrect manner of terminating the process (#1596)

* fix issue#1597: add rocksdb dependency to pstd (#1599)

* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>

* fix_info_command

* fix: gcc13 compile failed (#1601)

* ci: add unit test to github action (#1604)

* ci: add unit test in github workflow

* chore:change `PLATFORM` field logic (#1615)

* fix issue 1517: scan 命令不支持 type 参数 (#1582)

* fix: the unit test of type/set (#1617)

* test: optimize the return results of srandmember to avoid approximate results

* fix: use last_seed for random engine

* [fix issue1621] fix deadlock (#1620)

* [fix] fix deadlock

* [fix] fix

* command `type` and `ptype` add unit test

* fix member variable initialization

* Update issue templates

* feat: supported 'ptype' command

* fix unit test:type/set (#1577)

* fix issue#1597: add rocksdb dependency to pstd (#1599)

* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>

* fix: gcc13 compile failed (#1601)

* fix: the unit test of type/set (#1617)

* test: optimize the return results of srandmember to avoid approximate results

* fix: use last_seed for random engine

* Modify other modules to use the new `type` function

* fix function repeat

---------

Co-authored-by: Yuecai Liu <[email protected]>
Co-authored-by: liuyuecai <[email protected]>
Co-authored-by: Peter Chan <[email protected]>
Co-authored-by: chenbt <[email protected]>
Co-authored-by: Junhua Chen <[email protected]>
Co-authored-by: cjh <[email protected]>
Co-authored-by: kang jinci <[email protected]>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: machinly <[email protected]>
Co-authored-by: A2ureStone <[email protected]>
Co-authored-by: J1senn <[email protected]>
Co-authored-by: chejinge <[email protected]>
Co-authored-by: baerwang <[email protected]>
Co-authored-by: ptbxzrt <[email protected]>
Co-authored-by: 你不要过来啊 <[email protected]>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
* feat: supported 'ptype' command

* Simplified command `type` and `ptype` code

* Remove the capacity judgment

* fix slavaof serialize response bug (OpenAtomFoundation#1583)

Co-authored-by: liuyuecai <[email protected]>

* fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588)

* fix unit test:type/set (OpenAtomFoundation#1577)

* Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (OpenAtomFoundation#1590)

* fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg).

* add address/thread sanitizer to CMakeLists

---------

Co-authored-by: cjh <[email protected]>

* refactor: replace pstd/env with std::filesystem (OpenAtomFoundation#1470)

* fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (OpenAtomFoundation#1595)

using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly

* fix: incorrect manner of terminating the process (OpenAtomFoundation#1596)

* fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599)

* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>

* fix_info_command

* fix: gcc13 compile failed (OpenAtomFoundation#1601)

* ci: add unit test to github action (OpenAtomFoundation#1604)

* ci: add unit test in github workflow

* chore:change `PLATFORM` field logic (OpenAtomFoundation#1615)

* fix issue 1517: scan 命令不支持 type 参数 (OpenAtomFoundation#1582)

* fix: the unit test of type/set (OpenAtomFoundation#1617)

* test: optimize the return results of srandmember to avoid approximate results

* fix: use last_seed for random engine

* [fix issue1621] fix deadlock (OpenAtomFoundation#1620)

* [fix] fix deadlock

* [fix] fix

* command `type` and `ptype` add unit test

* fix member variable initialization

* Update issue templates

* feat: supported 'ptype' command

* fix unit test:type/set (OpenAtomFoundation#1577)

* fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599)

* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>

* fix: gcc13 compile failed (OpenAtomFoundation#1601)

* fix: the unit test of type/set (OpenAtomFoundation#1617)

* test: optimize the return results of srandmember to avoid approximate results

* fix: use last_seed for random engine

* Modify other modules to use the new `type` function

* fix function repeat

---------

Co-authored-by: Yuecai Liu <[email protected]>
Co-authored-by: liuyuecai <[email protected]>
Co-authored-by: Peter Chan <[email protected]>
Co-authored-by: chenbt <[email protected]>
Co-authored-by: Junhua Chen <[email protected]>
Co-authored-by: cjh <[email protected]>
Co-authored-by: kang jinci <[email protected]>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: machinly <[email protected]>
Co-authored-by: A2ureStone <[email protected]>
Co-authored-by: J1senn <[email protected]>
Co-authored-by: chejinge <[email protected]>
Co-authored-by: baerwang <[email protected]>
Co-authored-by: ptbxzrt <[email protected]>
Co-authored-by: 你不要过来啊 <[email protected]>
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>
cheniujh added a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
* feat: supported 'ptype' command

* Simplified command `type` and `ptype` code

* Remove the capacity judgment

* fix slavaof serialize response bug (OpenAtomFoundation#1583)

Co-authored-by: liuyuecai <[email protected]>

* fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588)

* fix unit test:type/set (OpenAtomFoundation#1577)

* Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (OpenAtomFoundation#1590)

* fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg).

* add address/thread sanitizer to CMakeLists

---------

Co-authored-by: cjh <[email protected]>

* refactor: replace pstd/env with std::filesystem (OpenAtomFoundation#1470)

* fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (OpenAtomFoundation#1595)

using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly

* fix: incorrect manner of terminating the process (OpenAtomFoundation#1596)

* fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599)

* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>

* fix_info_command

* fix: gcc13 compile failed (OpenAtomFoundation#1601)

* ci: add unit test to github action (OpenAtomFoundation#1604)

* ci: add unit test in github workflow

* chore:change `PLATFORM` field logic (OpenAtomFoundation#1615)

* fix issue 1517: scan 命令不支持 type 参数 (OpenAtomFoundation#1582)

* fix: the unit test of type/set (OpenAtomFoundation#1617)

* test: optimize the return results of srandmember to avoid approximate results

* fix: use last_seed for random engine

* [fix issue1621] fix deadlock (OpenAtomFoundation#1620)

* [fix] fix deadlock

* [fix] fix

* command `type` and `ptype` add unit test

* fix member variable initialization

* Update issue templates

* feat: supported 'ptype' command

* fix unit test:type/set (OpenAtomFoundation#1577)

* fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599)

* fix g++15 compile failure

* add rocksdb dependency to pstd

---------

Co-authored-by: J1senn <[email protected]>

* fix: gcc13 compile failed (OpenAtomFoundation#1601)

* fix: the unit test of type/set (OpenAtomFoundation#1617)

* test: optimize the return results of srandmember to avoid approximate results

* fix: use last_seed for random engine

* Modify other modules to use the new `type` function

* fix function repeat

---------

Co-authored-by: Yuecai Liu <[email protected]>
Co-authored-by: liuyuecai <[email protected]>
Co-authored-by: Peter Chan <[email protected]>
Co-authored-by: chenbt <[email protected]>
Co-authored-by: Junhua Chen <[email protected]>
Co-authored-by: cjh <[email protected]>
Co-authored-by: kang jinci <[email protected]>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: machinly <[email protected]>
Co-authored-by: A2ureStone <[email protected]>
Co-authored-by: J1senn <[email protected]>
Co-authored-by: chejinge <[email protected]>
Co-authored-by: baerwang <[email protected]>
Co-authored-by: ptbxzrt <[email protected]>
Co-authored-by: 你不要过来啊 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants