Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix binlog sender confict at multi-network interface #234

Merged
merged 4 commits into from Mar 22, 2018
Merged

bugfix binlog sender confict at multi-network interface #234

merged 4 commits into from Mar 22, 2018

Conversation

Leviathan1995
Copy link
Contributor

@Leviathan1995 Leviathan1995 commented Jan 15, 2018 •
edited
Loading

bugfix:

@KernelMaker
Copy link
Collaborator

还得调整一下rlimit RLIMIT_NOFILE，参考一下pika 初始化和redis config set的实现

KernelMaker
KernelMaker reviewed Jan 29, 2018
View reviewed changes
src/pika_binlog_receiver_thread.cc
// if (!g_pika_server->ShouldAccessConnAsMaster(ip)) {
// LOG(WARNING) << "BinlogReceiverThread AccessHandle failed: " << ip;
// return false;
// }
g_pika_server->PlusMasterConnection();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不对吧，要是一个非法连接连进来，也Plus？那不是有问题了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的连接都是放进来的，然后通过第一条命令auth sid来判断来源合法.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

执行PLUS会把status变成CONNECTED吧

@Leviathan1995 Leviathan1995 merged commit bcba759 into OpenAtomFoundation:master Mar 22, 2018
chejinge pushed a commit to chejinge/pika that referenced this pull request Oct 27, 2023
@AlexStocks
Merge pull request OpenAtomFoundation#234 from chejinge/feature/cache…
4ddc9a7 
…_string

redis cache:add dependences
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@Leviathan1995
bugfix binlog sender confict at multi-network interface (OpenAtomFoun…
4dd908d 
…dation#234)

* bugfix binlog sender confict at multi-network interface

* bugfix configing set maxclients has no effect

* set resource
       limits
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
@Leviathan1995
bugfix binlog sender confict at multi-network interface (OpenAtomFoun…
f5997d4 
…dation#234)

* bugfix binlog sender confict at multi-network interface

* bugfix configing set maxclients has no effect

* set resource
       limits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KernelMaker KernelMaker KernelMaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leviathan1995 @KernelMaker