fix: fix variable init error #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pika_conf.cc
Outdated
| if (max_background_flushes_ >= 4) { | ||
| max_background_flushes_ = 4; | ||
| if (max_background_flushes_ >= 6) { | ||
| max_background_flushes_ = 6; | ||
| } | ||
|
|
||
| max_background_compactions_ = 2; |
There was a problem hiding this comment.
默认值直接在声明的时候定义或者在初始化列表中定义，这里可以只做检查。
AlexStocks
approved these changes
Feb 27, 2024
dingxiaoshuai123
approved these changes
Feb 27, 2024
AlexStocks
merged commit 168d848
into
OpenAtomFoundation:unstable
11 of 13 checks passed
wangshao1
pushed a commit
to wangshao1/pika
that referenced
this pull request
Mar 4, 2024
* fix variable init error * fix by review comments --------- Co-authored-by: wangshaoyi <[email protected]>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* fix variable init error * fix by review comments --------- Co-authored-by: wangshaoyi <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* fix variable init error * fix by review comments --------- Co-authored-by: wangshaoyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复变量未设置初始值或初始值设置错误的bug。