fix:slots rebalance error and replication stats error when use pika o… #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perater * Update replication_test.go --------- Co-authored-by: chejinge <[email protected]>
AlexStocks
reviewed
May 14, 2024
| @@ -45,6 +45,15 @@ wait_master_registered() { | |||
| done | |||
| } | |||
|
|
|||
| wait_all_master_registered() { | |||
| for ((group_id=1; group_id <= GROUP_ID; group_id++)); do | |||
There was a problem hiding this comment.
group_id=1 改为 group_id = 1
There was a problem hiding this comment.
group_id=1 改为 group_id = 1
done
…perater * Update replication_test.go --------- Co-authored-by: chejinge <[email protected]>
AlexStocks
approved these changes
May 14, 2024
Mixficsol
approved these changes
May 14, 2024
chejinge
added a commit
that referenced
this pull request
May 15, 2024
#2651) * fix:slots rebalance error and replication stats error when use pika operater * Update replication_test.go --------- Co-authored-by: chejinge <[email protected]>
chenbt-hz
pushed a commit
to chenbt-hz/pika
that referenced
this pull request
Jun 3, 2024
OpenAtomFoundation#2651) * fix:slots rebalance error and replication stats error when use pika operater * Update replication_test.go --------- Co-authored-by: chejinge <[email protected]>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
OpenAtomFoundation#2651) * fix:slots rebalance error and replication stats error when use pika operater * Update replication_test.go --------- Co-authored-by: chejinge <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
OpenAtomFoundation#2651) * fix:slots rebalance error and replication stats error when use pika operater * Update replication_test.go --------- Co-authored-by: chejinge <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
OpenAtomFoundation#2651) * fix:slots rebalance error and replication stats error when use pika operater * Update replication_test.go --------- Co-authored-by: chejinge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.这个PR主要是修复slotsrebalance可能分配不均衡的问题：
以前是等待最大的group_id的master注册成功后去均衡，现在是等待所有的
2.修复注册之后有的group主从关系绑定失败的问题
3.添加一键部署脚本和部署调试脚本