fix:slave_prorority need to be 100 when used redis sentinel

[chejinge]

#2793

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the default slave priority setting from 0 to 100 to improve failover behavior.

[coderabbitai]

Walkthrough

The primary change involved modifying the slave_priority_ variable within the PikaConf class from 0 to 100. This alteration impacts the initial priority setting for the slave component, potentially influencing the behavior of the system regarding load balancing or task assignment.

Changes

Files	Change Summary
include/pika_conf.h	slave_priority_ variable in PikaConf class changed from 0 to 100.

Poem

In the code where bits align,
A change was made, a subtle sign.
Slave's priority, a hundred strong,
In Pika's heart, it won't go wrong.
🎉💻 The rabbits cheer, the code refined! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f4cfbde and ed140a9.

Files selected for processing (1)

• include/pika_conf.h (1 hunks)

Additional comments not posted (1)

include/pika_conf.h (1)

894-894: LGTM! But verify the impact of the new slave_priority_ value.

The change from 0 to 100 for slave_priority_ is straightforward and looks good. However, ensure that this new value aligns with the intended behavior of the system and does not introduce any unintended consequences.

To verify, check for any dependencies or assumptions in the codebase that rely on the old value.

Verification successful

---

LGTM! But verify the impact of the new slave_priority_ value.

The change from 0 to 100 for slave_priority_ is straightforward and looks good. However, ensure that this new value aligns with the intended behavior of the system and does not introduce any unintended consequences.

• The slave_priority_ variable is read and set in several places within the codebase.
• There are no specific comments or documentation indicating assumptions about its value.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the new `slave_priority_` value.

# Test: Search for the usage of `slave_priority_` in the codebase. Expect: No assumptions on the old value.
rg --type cpp -A 5 $'slave_priority_'

Length of output: 1663

---

Script:

#!/bin/bash
# Description: Gather detailed information on the usage of `slave_priority_` in the codebase.

# Search for the usage of `slave_priority_` in the codebase with more context.
rg --type cpp -A 10 -B 10 $'slave_priority_'

Length of output: 5892

---

Script:

#!/bin/bash
# Description: Check for any documentation or comments related to `slave_priority_` to understand its intended usage.

# Search for any comments or documentation mentioning `slave_priority_`.
rg --type cpp -A 5 -B 5 'slave_priority_'

Length of output: 3054