Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protect mode for new leader sync and commit binlog #946

Conversation

heroming
Copy link
Contributor

For pika writing binlog and use consensus, master respond client SUCCESS just when command finish writing master's DB, but before slave receive next sync message, binlog will not write to slave's DB. Worse still, if master crash before next sync message send, all slave DB will not have the last data, and then one of slave become new master, we must waiting for all binlog write DB before respond to new command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants