fix:Bind dbno to the client. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingxiaoshuai123
requested review from
panlei-coder,
longfar-ncy,
Centurybbx and
lqxhub
lqxhub
reviewed
Feb 1, 2024
src/client.h
Outdated
| @@ -211,7 +215,7 @@ class PClient : public std::enable_shared_from_this<PClient>, public CmdRes { | |||
|
|
|||
| PProtoParser parser_; | |||
|
|
|||
| int db_ = -1; | |||
| int db_; | |||
There was a problem hiding this comment.
这里是不是也给个默认值0, 我记得有的client 在连上后不会自动执行 select 0 命令的, 那这时候 应该默认选择 0 db
There was a problem hiding this comment.
PClient 的构造函数中将其初始化为0了，这里给不给默认都会在构造函数中设置其为0.
There was a problem hiding this comment.
感觉可以统一一下吧 之前雨哥说像这种简单变量最好是直接在这里给一个初始值
panlei-coder
approved these changes
Feb 1, 2024
AlexStocks
approved these changes
Feb 1, 2024
dingxiaoshuai123
pushed a commit
to dingxiaoshuai123/pikiwidb
that referenced
this pull request
Mar 6, 2024
* add slot nums to config (OpenAtomFoundation#145) * fix migrate list slot logic (OpenAtomFoundation#156) * fix sadd slot (OpenAtomFoundation#157) Co-authored-by: liuyuecai <[email protected]> --------- Co-authored-by: liuyuecai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将 dbindex 与 client 绑定在一起，执行命令的时候，传入 client 中的 index 去访问 db 。select 时，改变 client 中的 dbindex。