Updates to support Eclipse 2024-06 #514
Conversation
mezarin
force-pushed
the
eclipse202406Updates2
branch
3 times, most recently
from
751167b
to
304818b
Compare
mezarin
force-pushed
the
eclipse202406Updates2
branch
3 times, most recently
from
642f045
to
0bd90b7
Compare
mezarin
force-pushed
the
eclipse202406Updates2
branch
from
0bd90b7
to
abf057f
Compare
mezarin
force-pushed
the
eclipse202406Updates2
branch
from
abf057f
to
149eb3a
Compare
| if (rootCause != null && rootCause instanceof IllegalArgumentException) { | ||
| String message = rootCause.getMessage(); | ||
|
|
||
| if (message != null && message.contains("Unsupported class file major version 65")) { |
There was a problem hiding this comment.
Does this tie us to English language? If so, that's probably OK and we could fix later if needed.
There was a problem hiding this comment.
The message is not something we produce, but something a message from the exception that we check. I know this is not optimal of preferred.
| @@ -0,0 +1,127 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
Path should be:
releng/target-platform-3Q2024/target-platform-3Q2024.target
There was a problem hiding this comment.
Thanks for catching that. I updated it.
|
Noting this issue is held up by eclipse-jdtls/eclipse.jdt.ls#3236 and google/gson#2725. The likely resolution will be to wait for the next release of JDT LS with a likely target of the end of August, since it is already fixed in the main branch, rather than a more clever resolution of the issues. Note a workaround is to delete each of these from the plugins pool dir:
and then restart Eclipse with Actually, knowing we have this workaround we could probably consider proceeding and ultimately merging this PR. But we might also wait a few days to see what other reaction comes from these two issues in case we want to address it as part of this "bringup" PR. |
No description provided.