Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build rocev2_ip_list for disaggregated hosts #49

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

velomatt
Copy link
Contributor

  • this is a new change needed for rdd
  • previously we only neded rocev2_ip_list for targets
  • now we need it for disag. hosts or deploy will fail
  • just removing the included_targets condition fixes this

- this is a new change needed for rdd
- previously we only neded rocev2_ip_list for targets
- now we need it for disag. hosts or deploy will fail
- just removing the `included_targets` condition fixes this
@velomatt velomatt requested a review from a team as a code owner July 11, 2023 21:56
@velomatt
Copy link
Contributor Author

Tested in 1-node target / 1-node host disaggregated cluster. This should not affect other deployment modes

@velomatt velomatt requested a review from nsarras July 11, 2023 21:57
Copy link
Contributor

@nsarras nsarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@velomatt velomatt merged commit 73c919c into master Jul 11, 2023
1 check passed
@velomatt velomatt deleted the fix-disaggregated-host-deploy-rdd2 branch July 11, 2023 22:37
velomatt added a commit that referenced this pull request Mar 25, 2024
Build rocev2_ip_list for disaggregated hosts (#49)

See merge request dss/dss-ansible!11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants