Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update paths for s3 benchmark #60

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Update paths for s3 benchmark #60

merged 4 commits into from
Nov 10, 2023

Conversation

velomatt
Copy link
Contributor

@velomatt velomatt commented Nov 9, 2023

  • s3-benchmark is no longer packed with minio artifact
  • s3-benchmark is now packaged with client-library
  • paths need to be updated to reflect this change (both in play as well as documentation)
  • in testing a minor regression was identified. Some tasks fail for an unexplained reason on latest version of ansible 2.9, but the problem goes away when the full path of the module name is supplied, rather than just the short name

@velomatt velomatt requested a review from a team as a code owner November 9, 2023 21:12
snubatreus
snubatreus approved these changes Nov 10, 2023
View reviewed changes
Copy link

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@velomatt velomatt merged commit e227447 into master Nov 10, 2023
1 check passed
@velomatt velomatt deleted the update-paths-for-s3-benchmark branch November 10, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snubatreus snubatreus snubatreus approved these changes

Assignees

@nsarras nsarras

@velomatt velomatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@velomatt @snubatreus @nsarras