Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map information tool: Information about the map properties #2125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dl3sdo
Copy link
Member

@dl3sdo dl3sdo commented Jan 14, 2023

The map information tool informs about the number of map objects, templates and undo-/redo-steps.
It informs about the number and names of map parts, symbols, colors, and fonts.
It shows for each color the symbol(s) using the color.
For each symbol in use the tools shows the used color(s) and the number of related objects.

MapInfoExample

@dl3sdo
Copy link
Member Author

dl3sdo commented Jan 18, 2023

Any proposals for additional features?

@lpechacek lpechacek self-requested a review January 18, 2023 10:13
@dl3sdo dl3sdo mentioned this pull request Jan 19, 2023
@dl3sdo dl3sdo marked this pull request as ready for review June 20, 2023 11:48
@dl3sdo dl3sdo mentioned this pull request Jun 27, 2023
@dg0yt
Copy link
Member

dg0yt commented Apr 14, 2024

For consistent naming, this should probably come as class MapInformationDialog, in map_information_dialog files.

@dg0yt dg0yt self-requested a review April 14, 2024 12:58
@dl3sdo dl3sdo marked this pull request as draft April 14, 2024 18:58
@dl3sdo dl3sdo marked this pull request as ready for review April 15, 2024 13:07
@dl3sdo dl3sdo marked this pull request as draft April 17, 2024 12:51
@dl3sdo
Copy link
Member Author

dl3sdo commented Apr 17, 2024

The PR needs to be adapted due to changes in #2158, thus the merge of #2158 shall be done first.

@dl3sdo
Copy link
Member Author

dl3sdo commented Aug 2, 2024

Reminder to me: Add new .cpp file to code-check-wrapper.sh

@dl3sdo dl3sdo force-pushed the mapinfo branch 4 times, most recently from b79daf8 to 60d8eba Compare August 7, 2024 15:08
@dl3sdo
Copy link
Member Author

dl3sdo commented Aug 7, 2024

MapInformationNew
Now with possibility to export the report as text file.

@dl3sdo dl3sdo marked this pull request as ready for review August 8, 2024 16:29
@dl3sdo
Copy link
Member Author

dl3sdo commented Aug 8, 2024

As #2158 is not scheduled for the upcoming release I propose to assess whether this PR could be merged before #2158. An update due to #2158 is straightforward.

@krticka
Copy link
Contributor

krticka commented Oct 4, 2024

Hi, I really appreciate the implementation of Map information tool. I have comments only on the information about the coordinate system, when the info "by EPSG code" is shown. I think this is rather insufficient information and EPSG value + Coordinate system name (zone) should be shown.
image

The map information tool informs about the number of map objects,
templates and undo-/redo-steps.
It informs about the number and names of map parts, symbols, colors,
and fonts.
It shows for each color the symbol(s) using the color.
For each symbol in use the tool shows the used color(s) and the number
of related objects.
The report can be exported as text file.
@dl3sdo
Copy link
Member Author

dl3sdo commented Oct 5, 2024

@krticka: thank you for your feedback. I extended the information about the CRS. However, I don't know how I can easily derive the UTM zone from the EPSG code so I just added the zone or code for UTM, GK and EPSG:
CRSInfo

@krticka
Copy link
Contributor

krticka commented Oct 6, 2024

@dl3sdo Thank you for this improvement. Every zone usually has its own EPSG code, so there is no need to bother with it. Information about coordinate system can be easily extended if the code will be active hyperlink to the web EPSG database, e.g. https://epsg.io/25832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants