Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly setting locales for pip installs, Fixes #38 #39

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Correctly setting locales for pip installs, Fixes #38 #39

merged 1 commit into from
Jul 20, 2018

Conversation

Benvii
Copy link
Member

@Benvii Benvii commented Jul 14, 2018

Correct local for pip installs so that it can decode files correctly in UTF8.

@Benvii Benvii requested a review from Valdimus July 14, 2018 10:07
@Benvii
Copy link
Member Author

Benvii commented Jul 14, 2018

Please review and merge this before testing :
OpenPathView/OPV_DBRest#36

@zyioump zyioump self-assigned this Jul 16, 2018
@Benvii
Copy link
Member Author

Benvii commented Jul 18, 2018

Can someone review it please ? Will need working version of Ansible to treat CBNB data this weekend. cc @Valdimus @zyioump

zyioump
zyioump approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@zyioump zyioump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in container, got no error during install and config, i tried an import and it work

@Benvii Benvii merged commit 46ddc01 into master Jul 20, 2018
@Benvii Benvii deleted the ascii_decode_pip branch July 20, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyioump zyioump zyioump approved these changes

@Valdimus Valdimus Awaiting requested review from Valdimus

Assignees

@zyioump zyioump

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benvii @zyioump