Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of order timestamps in bulk file import #1350

Closed
Jonathan34 opened this issue Sep 25, 2018 · 2 comments
Closed

Out of order timestamps in bulk file import #1350

Jonathan34 opened this issue Sep 25, 2018 · 2 comments
Labels

Comments

@Jonathan34
Copy link

Jonathan34 commented Sep 25, 2018

From: OpenTSDB/opentsdb.net#99
Property tsd.core.bulk.allow_out_of_order_timestamps does not work in 2.3.1 version. Documentation says it s supported in 2.3...: http://opentsdb.net/docs/build/html/user_guide/configuration.html

From #572 it seems to be in 2.4 snapshot only
:(

New timestamp=1537857720387 is less than or equal to previous=1537859699781 when trying to add value=[91, -87, -108, 49] to IncomingDataPoints([0, 0, 87, 91, -87, -36, -16, 0, 0, 1, 0, 0, 1, 0, 0, 2, 0, 0, 18, 0, 0, 3, 0, 0, 18, 0, 0, 4, 0, 0, 15] (metric=AcqTime), base_time=1537858800 (Tue Sep 25 07:00:00 UTC 2018), []) at net.opentsdb.core.IncomingDataPoints.addPointInternal(IncomingDataPoints.java:289) ~[tsdb-2.3.1.jar:eca1ef41] at net.opentsdb.core.IncomingDataPoints.addPoint(IncomingDataPoints.java:395) ~[tsdb-2.3.1.jar:eca1ef41] at net.opentsdb.tools.TextImporter.importFile(TextImporter.java:194) [tsdb-2.3.1.jar:eca1ef41] at net.opentsdb.tools.TextImporter.main(TextImporter.java:76) [tsdb-2.3.1.jar:eca1ef41]
{"short_revision":"eca1ef41","repo":"/opentsdb/build","host":"67024e5790cf","version":"2.3.1","full_revision":"eca1ef413bfde7cde5450e093d544118e0877ef0","repo_status":"MINT","user":"root","branch":"master","timestamp":"1537367591"}

Writing to Google Big Table...

Any workaround for this rather that sorting out the order (which is very hard in my case)?

@twegener-embertec
Copy link

OpenTSDB devs: Would it be possible to get the tsd.core.bulk.allow_out_of_order_timestamps option into a 2.3.x release? Without this, it means that 'tsdb scan' / 'tsdb import' does not round-trip when occasionally out-of-order data points are present (and they can be legitimately present). It seems like it is a bug if 'tsdb scan' / 'tsdb import' doesn't round-trip in all cases.

(I've manually brought in the patch for that into 2.3.0/2.3.1, and it seems to work fine:
71f35ca
It would be nice to have that in the release proper.)

@manolama
Copy link
Member

@Jonathan34 @twegener-embertec Sounds good, I merged in in 072a825 and it'll be in 2.3.2

@manolama manolama added the bug label Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants