Fix bug with votes count
#1585
Merged
Fix bug with votes count
#1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Script up to down or down to up improperly counts script votes and messes up good/bad bar. Shouldn't affect Rating in Script or Group but will recheck a few. * At the same time move to MVC *(Currently isolated to Script e.g. parallel change)*... Fixes TODO in routes.js * Some styleguide.md conformance * Simplify some views. e.g. turn some things off when they aren't able to be used. Save b/w and possibly improve understanding for most * Still would prefer returning `err` *(aErr)* with libs but that's probably a separate PR since there are still inconsistent return callback parms * Some filling in for OpenUserJS#1548 * Some additions for OpenUserJS#430. e.g. we want to know if a DB action fails currently NOTES: * Structure mirrored and altered from `flagsLib` Applies to OpenUserJS#262 and Active Maintainer override (Sorry sizzle but needed to be done so it doesn't mess up other areas down the line) * Will run through scripts and mitigate any script `votes` counts.
Martii
added
bug
Martii
commented
Feb 10, 2019
| return; | ||
| } else if (aVoteModel.vote !== vote) { | ||
| aVoteModel.vote = vote; | ||
| aScript.rating += vote ? 2 : -2; |
There was a problem hiding this comment.
The bug of missing inverse the votes count.
Martii
commented
Feb 10, 2019
| if (aVote.vote !== aCasting) { | ||
| aVote.vote = aCasting; | ||
| aScript.rating += (aCasting ? 2 : -2); | ||
| aScript.votes = aScript.votes + (aCasting ? 2 : -2); |
There was a problem hiding this comment.
The bug fix of missing inverse the votes count.
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 10, 2019
Post OpenUserJS#1585 and applies to OpenUserJS#262
Martii
added a commit
that referenced
this pull request
Feb 10, 2019
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 12, 2019
* Transcription error from inline to MVC. My bad. * Notate in model Applies to OpenUserJS#262 and post OpenUserJS#1585
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
err(aErr) with libs but that's probably a separate PR since there are still inconsistent return callback parmsconsolemessages are to be production/development/debug environment #430. e.g. we want to know if a DB action fails currentlyNOTES:
flagsLibApplies to Remove redundant legacy code and improve overall consistency #262 and Active Maintainer override (Sorry sizzle but needed to be done so it doesn't mess up other areas down the line)
votescounts.Reversal of a portion of the PR due to transcription error... no mitigation needed at this time. Still MVC.