Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair so error on npm -ls becomes a warning #833

Merged
merged 1 commit into from
Nov 19, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Nov 19, 2015

  • Added try...catch just in case it's a fatal error

NOTES

problems": [

    "peer dep missing: kerberos@~0.0, required by [email protected]"

],

... this shows up in the stdout (near the top) as being the "error" along with the full compliment of packages installed ... see #832 and parent #318

(never would have guessed this on nodejitsu... glad we aren't there anymore)

* Added `try...catch` just in case it's a fatal error

**NOTES**

``` sh-session
problems": [

    "peer dep missing: kerberos@~0.0, required by [email protected]"

],
```

... this shows up in the stdout as being the "error" along with the full compliment of packages installed ... see OpenUserJS#832 and parent OpenUserJS#318

*(never would have guessed this on nodejitsu... glad we aren't there anymore)*
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Nov 19, 2015
Martii added a commit that referenced this pull request Nov 19, 2015
Repair so error on `npm -ls` becomes a warning

Auto-merge
@Martii Martii merged commit 655a7ed into OpenUserJS:master Nov 19, 2015
@Martii Martii deleted the modifyAdminNPMls branch November 19, 2015 06:26
@Martii
Copy link
Member Author

Martii commented Nov 19, 2015

Just a note... the "error" could also be thrown (and did locally) if a dependency was removed from ./package.json but not removed from ./node_modules... so this should cover those situations as well... for an indication that one should probably clean ./node_modules out and start fresh. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Development

Successfully merging this pull request may close these issues.

1 participant