Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure test coverage #1129

Closed
ggonzalez94 opened this issue Sep 4, 2024 · 1 comment · Fixed by #1152
Closed

Measure test coverage #1129

ggonzalez94 opened this issue Sep 4, 2024 · 1 comment · Fixed by #1152
Assignees
@ggonzalez94
Labels
github_actions Pull requests that update GitHub Actions code
Milestone
1. current

Comments

@ggonzalez94
Copy link
Collaborator

🧐 Motivation
Having clear test coverage is critical to know the quality of our codebase

📝 Details
With the migration to starknet foundry we gained a lot of things, but lost the ability to measure test coverage. Now that cairo-coverage is available we should look and see if it is mature enough to be integrated into the codebase.
This should be included as part of the CI and coverage reports uploaded to Codecov.
@ggonzalez94 ggonzalez94 added the github_actions Pull requests that update GitHub Actions code label Sep 4, 2024
@ggonzalez94 ggonzalez94 added this to the 2. next milestone Sep 4, 2024
@ggonzalez94
Copy link
Collaborator Author

Blocked by #1135 - we need to upgrade our starknet foundry version

@ggonzalez94 ggonzalez94 mentioned this issue Sep 6, 2024
Merged
3 tasks
@ggonzalez94 ggonzalez94 mentioned this issue Sep 18, 2024
Merged
@ggonzalez94 ggonzalez94 self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggonzalez94 ggonzalez94

Labels
github_actions Pull requests that update GitHub Actions code
Projects
Contracts for Cairo
Status: ✅ Resolved
Milestone
1. current
Development

Successfully merging a pull request may close this issue.

Add coverage to our test workflow OpenZeppelin/cairo-contracts
1 participant
@ggonzalez94