Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate dualcase dispatchers #1155

Merged

Conversation

ericnordelo
Copy link
Member

Mark dual dispatchers as deprecated both in the CHANGELOG and the docsite, for users to be aware that they will be removed soon.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (be991c0) to head (bc9751d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          57       57           
  Lines        1375     1375           
=======================================
  Hits         1222     1222           
  Misses        153      153           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be991c0...bc9751d. Read the comment docs.

Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! What's the plan for removing them?

  • Deprecate as part of 0.17.0 release
  • Remove them on 0.18.0?

@ericnordelo
Copy link
Member Author

That's the idea, yes

@ericnordelo ericnordelo merged commit 715b5e4 into OpenZeppelin:main Sep 23, 2024
8 checks passed
@ericnordelo ericnordelo deleted the feat/deprecate-dual-dispatchers branch September 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants