Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure queues with server side encryption #216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Secure queues with server side encryption #216

wants to merge 2 commits into from

Conversation

tuoruu
Copy link
Contributor

@tuoruu tuoruu commented Mar 3, 2023

This needs to be tested in test environments, adding server-side encryption disables "anonymous" usage. I hope we don't have anonymous usage. SSL-enforcement could also be enabled but didn't want to have two changes in one branch.

  • fix some imports with cdk style
  • remove extra parentheses from Duration
  • add server-side encryption for all queues

@tuoruu tuoruu requested review from tomikat and severij March 3, 2023 12:54
tomikat
tomikat approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@tomikat tomikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Need to test this in QA, if anything needs to be done to ehoks side (that writes to herätepalvelu queues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomikat tomikat tomikat approved these changes

@severij severij severij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuoruu @tomikat @severij