Skip to content

Commit

Permalink
feat(accordion): add padding to accordion content (#1727)
Browse files Browse the repository at this point in the history
Co-authored-by: louismaxime.piton <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
  • Loading branch information
3 people authored Dec 30, 2022
1 parent 2001a10 commit 20d8f0c
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 5 deletions.
8 changes: 5 additions & 3 deletions scss/_accordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@
// Boosted mod: no --#{$prefix}accordion-btn-active-icon
// Boosted mod: no --#{$prefix}accordion-btn-focus-border-color
// Boosted mod: no --#{$prefix}accordion-btn-focus-box-shadow
--#{$prefix}accordion-body-padding-x: #{$accordion-body-padding-x};
--#{$prefix}accordion-body-padding-y: #{$accordion-body-padding-y};
--#{$prefix}accordion-body-padding-top: #{$accordion-body-padding-top}; // Boosted mod
--#{$prefix}accordion-body-padding-end: #{$accordion-body-padding-end}; // Boosted mod
--#{$prefix}accordion-body-padding-bottom: #{$accordion-body-padding-bottom}; // Boosted mod
--#{$prefix}accordion-body-padding-start: #{$accordion-body-padding-start}; // Boosted mod
--#{$prefix}accordion-active-color: #{$accordion-button-active-color};
--#{$prefix}accordion-active-bg: #{$accordion-button-active-bg};
// scss-docs-end accordion-css-vars
Expand Down Expand Up @@ -123,7 +125,7 @@
}

.accordion-body {
padding: 0 var(--#{$prefix}accordion-body-padding-x) var(--#{$prefix}accordion-body-padding-y) 0; // Boosted mod
padding: var(--#{$prefix}accordion-body-padding-top) var(--#{$prefix}accordion-body-padding-end) var(--#{$prefix}accordion-body-padding-bottom) var(--#{$prefix}accordion-body-padding-start); // Boosted mod
}

// Boosted mod: no Flush accordion items
Expand Down
10 changes: 8 additions & 2 deletions scss/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -1563,8 +1563,14 @@ $accordion-border-color: $gray-500 !default; // Boosted mod
$accordion-border-radius: $border-radius !default;
$accordion-inner-border-radius: subtract($accordion-border-radius, #{$accordion-border-width}) !default;

$accordion-body-padding-y: $spacer !default; // Boosted mod
$accordion-body-padding-x: $spacer !default; // Boosted mod
$accordion-body-padding-top: 5px !default; // Boosted mod
$accordion-body-padding-end: $spacer !default; // Boosted mod
$accordion-body-padding-bottom: $spacer !default; // Boosted mod
$accordion-body-padding-start: 0 !default; // Boosted mod
// fusv-disable
$accordion-body-padding-y: $spacer !default; // Deprecated in Boosted 5.2.3 to divide it in -padding<top | end | bottom |start>
$accordion-body-padding-x: $spacer !default; // Deprecated in Boosted 5.2.3 to divide it in -padding<top | end | bottom |start>
// fusv-enable

$accordion-button-padding-y: $accordion-padding-y !default;
$accordion-button-padding-x: $accordion-padding-x !default;
Expand Down
12 changes: 12 additions & 0 deletions site/content/docs/5.2/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ If you need more details about the changes, please refer to the [v5.2.3 release]
- <details class="mb-2">
<summary><span class="badge bg-danger">Breaking</span> Deprecated CSS variables:</summary>
<ul>
<li><code>--bs-accordion-body-padding-x</code></li>
<li><code>--bs-accordion-body-padding-y</code></li>
<li><code>--bs-dropdown-toggle-bg</code></li>
<li><code>--bs-dropdown-toggle-border-color</code></li>
<li><code>--bs-dropdown-toggle-color</code></li>
Expand All @@ -147,6 +149,10 @@ If you need more details about the changes, please refer to the [v5.2.3 release]
- <details class="mb-2">
<summary><span class="badge bg-success">New</span> CSS variables:</summary>
<ul>
<li><code>--bs-accordion-body-padding-bottom</code></li>
<li><code>--bs-accordion-body-padding-end</code></li>
<li><code>--bs-accordion-body-padding-start</code></li>
<li><code>--bs-accordion-body-padding-top</code></li>
<li><code>--bs-dropdown-line-height</code></li>
<li><code>--bs-focus-visible-inner-color</code></li>
<li><code>--bs-focus-visible-outer-color</code></li>
Expand All @@ -161,6 +167,8 @@ If you need more details about the changes, please refer to the [v5.2.3 release]
- <details class="mb-2">
<summary><span class="badge bg-danger">Breaking</span> Deprecated Sass variables:</summary>
<ul>
<li><code>$accordion-body-padding-x</code></li>
<li><code>$accordion-body-padding-y</code></li>
<li><code>$btn-close-focus-shadow</code></li>
<li><code>$form-range-thumb-active-border</code></li>
<li><code>$form-star-focus-box-shadow</code></li>
Expand All @@ -176,6 +184,10 @@ If you need more details about the changes, please refer to the [v5.2.3 release]
- <details class="mb-2">
<summary><span class="badge bg-success">New</span> Sass variables:</summary>
<ul>
<li><code>$accordion-body-padding-bottom</code></li>
<li><code>$accordion-body-padding-end</code></li>
<li><code>$accordion-body-padding-start</code></li>
<li><code>$accordion-body-padding-top</code></li>
<li><code>$focus-visible-inner-color</code></li>
<li><code>$focus-visible-inner-color-dark</code></li>
<li><code>$focus-visible-inner-width</code></li>
Expand Down

0 comments on commit 20d8f0c

Please sign in to comment.