feat(focus-visible): drop outline removals everywhere

Orange-OpenSource · May 27, 2020 · 982dcec · 982dcec
1 parent 0ab40fb
commit 982dcec
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 14 deletions.
diff --git a/scss/_buttons.scss b/scss/_buttons.scss
@@ -27,7 +27,6 @@
 
  &:focus,
  &.focus {
- outline: 0;
  box-shadow: $btn-focus-box-shadow;
  }
 

diff --git a/scss/_carousel.scss b/scss/_carousel.scss
@@ -106,7 +106,6 @@
  &:focus {
  color: $carousel-control-color;
  text-decoration: none;
- outline: 0;
  opacity: $carousel-control-hover-opacity;
  }
 }

diff --git a/scss/_modal.scss b/scss/_modal.scss
@@ -24,9 +24,6 @@
  width: 100%;
  height: 100%;
  overflow: hidden;
- // Prevent Chrome on Windows from adding a focus outline. For details, see
- // https:/twbs/bootstrap/pull/10951.
- outline: 0;
  // We deliberately don't use `-webkit-overflow-scrolling: touch;` due to a
  // gnarly iOS Safari bug: https://bugs.webkit.org/show_bug.cgi?id=158342
  // See also https:/twbs/bootstrap/issues/17695
@@ -88,8 +85,6 @@
  border: if($modal-content-border-color == null, null, $modal-content-border-width solid $modal-content-border-color); // Boosted mod
  @include border-radius($modal-content-border-radius);
  @include box-shadow($modal-content-box-shadow-xs);
- // Remove focus outline from opened modal
- outline: 0;
 }
 
 // Modal background

diff --git a/scss/_navbar.scss b/scss/_navbar.scss
@@ -205,7 +205,6 @@
 
  &:focus {
  text-decoration: none;
- outline: 0;
  box-shadow: 0 0 0 $navbar-toggler-focus-width;
  }
 

diff --git a/scss/forms/_form-check.scss b/scss/forms/_form-check.scss
@@ -39,7 +39,6 @@
 
  &:focus {
  border-color: $form-check-input-focus-border;
- outline: 0;
  box-shadow: $form-check-input-focus-box-shadow;
  }
 
@@ -166,7 +165,7 @@
  }
 
  &:focus {
- outline: 0; // @TODO: custom focus
+ // @TODO: custom focus
  }
 
  &:active {

diff --git a/scss/forms/_form-control.scss b/scss/forms/_form-control.scss
@@ -28,7 +28,6 @@
  color: $input-focus-color;
  background-color: $input-focus-bg;
  border-color: $input-focus-border-color;
- outline: 0;
  @if $enable-shadows {
  @include box-shadow($input-box-shadow, $input-focus-box-shadow);
  } @else {

diff --git a/scss/forms/_form-range.scss b/scss/forms/_form-range.scss
@@ -13,8 +13,6 @@
 
  &:focus {
  // Boosted mod: better focus visibility
- outline: none;
-
  // Pseudo-elements must be split across multiple rulesets to have an effect.
  // No box-shadow() mixin for focus accessibility.
  &::-webkit-slider-thumb {

diff --git a/scss/forms/_form-select.scss b/scss/forms/_form-select.scss
@@ -26,7 +26,6 @@
 
  &:focus {
  border-color: $form-select-focus-border-color;
- outline: 0;
  @if $enable-shadows {
  @include box-shadow($form-select-box-shadow, $form-select-focus-box-shadow);
  } @else {