Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Footer component in docs #1280

Merged
merged 10 commits into from
Jul 8, 2022
Merged

Use Footer component in docs #1280

merged 10 commits into from
Jul 8, 2022

Conversation

hannahiss
Copy link
Member

After an exchange with Cyriaque, we agreed to

  • Position the text to the right of the navigation links (so after these links).
  • Delete the line break after the first sentence.
  • Delete the list that surrounds the version number and the Netlify link.

Closes #1221

@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 0d7ada8
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/62c82a1a01809300085c4e4a
😎 Deploy Preview https://deploy-preview-1280--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some visual issues + one question

site/layouts/partials/footer.html Outdated Show resolved Hide resolved
site/layouts/partials/footer.html Outdated Show resolved Hide resolved
site/layouts/partials/footer.html Outdated Show resolved Hide resolved
@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation enhancement labels May 30, 2022
@julien-deramond julien-deramond changed the title Main his doc footer Use Footer component in docs May 31, 2022
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution looks good to me !

site/layouts/partials/footer.html Outdated Show resolved Hide resolved
site/layouts/partials/footer.html Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said before, LGTM!

@julien-deramond julien-deramond self-requested a review July 8, 2022 11:11
site/layouts/partials/footer.html Outdated Show resolved Hide resolved
site/layouts/partials/footer.html Outdated Show resolved Hide resolved
site/assets/scss/_footer.scss Outdated Show resolved Hide resolved
site/layouts/partials/footer.html Show resolved Hide resolved
site/layouts/partials/footer.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the footer component in Boosted documentation
3 participants