Buttons: Adding CSS var #1426
Merged
Buttons: Adding CSS var #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
75 tasks
|
1st commit : No need of CSS vars for |
It was done this way in order to be closer to Bs ! |
julien-deramond
approved these changes
Oct 13, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One question remains: Do we need to use
button-variantin.btn-no-outlineand.btn-social?I did it the other way (writting down all the variables) because from what I've seen, it lightens the bundle but I'm open minded on every argument.
It can be reviewed commit by commit if prefered and/or can be splited in different PRs.