Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): move 'Dark variant' sections out of 'Example' for alerts and accordions #1502

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

julien-deramond
Copy link
Member

For consistency with Bootstrap docs architecture, I propose to move 'Dark variant' section out of the 'Example' section for alerts and accordions.

In Bootstrap:

🙏 Please double-check if I haven't forgotten components in Boosted.

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels Aug 30, 2022
@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 4b41460
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/630dd892c936860008a222d1
😎 Deploy Preview https://deploy-preview-1502--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change dark offcanvas on Bs side to be more consistent!

LGTM on our side.

@julien-deramond julien-deramond merged commit 428fbd7 into main Aug 30, 2022
@julien-deramond julien-deramond deleted the main-jd-move-accordion-dark-variant-section branch August 30, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants