Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(footer): change .footer-terms default font size #1589

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 7, 2022

Related issues

Closes #1587

Description

Force default font size (14px) for .footer-terms.

Motivation & Context

Be compliant with the DSM.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 64fa83c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/636a721ac8beef000862e79c
😎 Deploy Preview https://deploy-preview-1589--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond marked this pull request as ready for review November 7, 2022 11:57
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen any regression, can you please double check ?

@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 7dbc41d into main Nov 8, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-footer-copyright-font-size branch November 8, 2022 15:22
@julien-deramond julien-deramond mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer: Copyright part have a too big font-size
2 participants