Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add cards RTL example #1603

Merged
merged 9 commits into from
Nov 9, 2022
Merged

Docs: add cards RTL example #1603

merged 9 commits into from
Nov 9, 2022

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Nov 8, 2022 •
edited by julien-deramond
Loading

Related issues

closes #1549

Description

  • Add category in site/data/examples.yml
  • Add cards RTL example file cards-rtl/index.html
  • Update _index.md as in Bootstrap https://getbootstrap.com/docs/5.2/examples/ in particular warning about RTL that is still experimental
  • Add 2 images in site/static/docs/5.2/assets/img/examples

Motivation & Context

Need of an RTL example

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 2.5%, saving 2.58 KB.

Filename Before After Improvement Visual comparison
site/static/docs/5.2/assets/img/examples/cards-rtl.png 30.33 KB 28.99 KB -4.4% View diff
site/static/docs/5.2/assets/img/examples/[email protected] 72.19 KB 70.96 KB -1.7% View diff

59 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@netlify
Copy link

netlify bot commented Nov 8, 2022

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c188a11
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/636a80cf836b1000085fda58
😎 Deploy Preview https://deploy-preview-1603--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 8, 2022 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1be081e
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/636bb7aaf3a4e30008c81ada
😎 Deploy Preview https://deploy-preview-1603--boosted.netlify.app/docs/5.2/examples/cards-rtl
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hannahiss hannahiss changed the title Docs : add cards RTL example Docs: add cards RTL example Nov 8, 2022
louismaximepiton
louismaximepiton requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 thing to tackle before approval!

site/content/docs/5.2/examples/cards-rtl/index.html Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/cards-rtl/index.html
<h6 class="card-text">شرح</h6>
</div>
<div class="card-footer bg-dark text-light pt-2">
<a class="btn btn-secondary" aria-label="وصف الزر" title="وصف الزر">زر</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some display are weird in GitHub but they looks good in the file in VSCode 🤔I need to check if there's an issue inside GitHub referencing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page rendering is OK in the browsers. The text is well-displayed in the IDE as well. So yeah, it must be an issue on GitHub side.

louismaximepiton
louismaximepiton approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-deramond

This comment was marked as resolved.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
18.7% 18.7% Duplication

julien-deramond
julien-deramond approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Made few minor changes in 4f4bb9d, 81a58b6 and 1be081e

@julien-deramond julien-deramond merged commit 0d29f42 into main Nov 9, 2022
@julien-deramond julien-deramond deleted the main-his-doc-card-rtl branch November 9, 2022 14:35
@julien-deramond julien-deramond mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
examples feature RTL v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce at least an example page for RTL
3 participants
@hannahiss @julien-deramond @louismaximepiton