Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Dropdown fixes #1793

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Docs: Dropdown fixes #1793

merged 3 commits into from
Feb 7, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 19, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Use .nav-link instead of .btn in a navbar.
Remove the cut border on split-dropdown when in show.
Remove border on .nav-link since we declare border on each nav.

Motivation & Context

Be closer to Bootstrap.
Fix some issues in the doc

Types of change

  • Bug fix (non-breaking which fixes an issues)
  • Refactoring (non-breaking change)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation fix css enhancement labels Jan 19, 2023
@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 15314aa
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63e249a44b237e0009f17a73
😎 Deploy Preview https://deploy-preview-1793--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't spotted any issues. No need to mention anything in the migration IMO so let's 🚀

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit b948f04 into main Feb 7, 2023
@julien-deramond julien-deramond deleted the main-lmp-dropdown-fixes branch February 7, 2023 12:56
@julien-deramond julien-deramond mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css docs Improvements or additions to documentation enhancement fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants