Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update color picker according to UI Kit v5 #1794

Merged
merged 16 commits into from
Feb 20, 2023
Merged

Update color picker according to UI Kit v5 #1794

merged 16 commits into from
Feb 20, 2023

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Jan 19, 2023 •
edited
Loading

Description

Update color picker design.
Closes #1360

Motivation & Context

Compliance to UI Kit v5.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@MewenLeHo MewenLeHo added v5 brand component docs Improvements or additions to documentation labels Jan 19, 2023
@netlify
Copy link

netlify bot commented Jan 19, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 8399067
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63f33388c4b7c30008e4c622
😎 Deploy Preview https://deploy-preview-1794--boosted.netlify.app/docs/5.3/forms/form-control
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MewenLeHo MewenLeHo mentioned this pull request Jan 19, 2023
Open
26 tasks
@MewenLeHo

This comment was marked as outdated.

Sign in to view
louismaximepiton

This comment was marked as outdated.

Sign in to view

@louismaximepiton louismaximepiton marked this pull request as draft January 19, 2023 13:54
@MewenLeHo MewenLeHo marked this pull request as ready for review January 19, 2023 15:42
louismaximepiton

This comment was marked as outdated.

Sign in to view

Aniort
Aniort approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a11y ok

louismaximepiton

This comment was marked as outdated.

Sign in to view

@Franco-Riccitelli
Copy link

I have made a design review of the colour picker and all is good. No comments.

louismaximepiton

This comment was marked as outdated.

Sign in to view

Aniort
Aniort reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, vocalization on NVDA under Chrome is bad "cliquable 65% red 52% green 84% blue", so I need to investigate much more...

@Aniort
Copy link
Contributor

Aniort commented Feb 13, 2023

a11y OK

Aniort
Aniort approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A11y warning text OK

@MewenLeHo MewenLeHo force-pushed the main-mlh-update-color-picker-new-ui-kit branch from 2e21b68 to 7764152 Compare February 14, 2023 08:42
julien-deramond
julien-deramond requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Support is not that bad actually, works well from Safari v12 for example.
Few details to fix/discuss and we're good to go 🚀

scss/_variables.scss Outdated Show resolved Hide resolved
scss/forms/_form-control.scss Outdated Show resolved Hide resolved
site/content/docs/5.3/forms/form-control.md Outdated Show resolved Hide resolved
site/content/docs/5.3/forms/form-control.md Outdated Show resolved Hide resolved
site/content/docs/5.3/migration.md Outdated Show resolved Hide resolved
@julien-deramond
Copy link
Member

@MewenLeHo Please fix the bundlewatch issue as well

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit eafb4ac into main Feb 20, 2023
@julien-deramond julien-deramond deleted the main-mlh-update-color-picker-new-ui-kit branch February 20, 2023 09:01
@julien-deramond julien-deramond mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniort Aniort Aniort approved these changes

@julien-deramond julien-deramond julien-deramond approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
brand component docs Improvements or additions to documentation passed a11y review passed design review v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs > Forms > Form Control > Color: Fix color picker default color
5 participants
@MewenLeHo @Franco-Riccitelli @Aniort @julien-deramond @louismaximepiton