Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary class for better consistency of the migration guide #1905

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Mar 16, 2023

Description

Remove unnecessary .text-danger-emphasis class.

Motivation & Context

Keep the migration guide consistent.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

https://deploy-preview-1905--boosted.netlify.app/docs/5.3/migration/#components

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices; I have at least run axe

Design

  • (NA) My change respects the design guidelines defined in Orange Design System
  • (NA) My change is compatible with responsive display

Development

  • (NA) My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • (NA) Design review
  • (NA) A11y review

After the merge

@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 634f76b
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64132757679c930008a61d11
😎 Deploy Preview https://deploy-preview-1905--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels Mar 16, 2023
@julien-deramond julien-deramond self-requested a review March 16, 2023 14:27
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond julien-deramond merged commit 3bc584e into main Mar 16, 2023
@julien-deramond julien-deramond deleted the main-mlh-fix-consistency-migration-guide branch March 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants