Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unit tests): drop .btn-secondary from carousel play/pause buttons #2306

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

julien-deramond
Copy link
Member

Description

This PR suggests changing the markup used to render the play/pause buttons in carousels' unit tests so that they use the same one as in https://boosted.orange.com/docs/5.3/components/carousel/#with-pauseplay-button:

<button type="button" class="btn btn-icon carousel-control-play-pause pause" data-bs-target="#carouselExamplePause" data-bs-play-text="Play Carousel" data-bs-pause-text="Pause Carousel" title="Pause Carousel">
  <span class="visually-hidden">Pause Carousel</span>
</button>

It basically means to drop the use of .btn-secondary.

Note: it'll help with the work in progress in #2223

Motivation & Context

Consistency between the carousels' markups.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

N/A

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 78ba1a7
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6527990a8e02500008221ca4
😎 Deploy Preview https://deploy-preview-2306--boosted.netlify.app/docs/5.3/about/team
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as ready for review October 12, 2023 06:46
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly the carousel's actual markup since the pause button is contained inside the carousel but I'm fine with the changes since it passes tests

@julien-deramond julien-deramond merged commit 18ace87 into main Oct 12, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-js-test-carousel branch October 12, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants