Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(back to top): drop useless CSS rule #2340

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 26, 2023

Description

This PR drops an unused rule for the back-to-top component. It was useful for the Label inside variant in v5.1.3 with the following markup:

<nav aria-label="Label inside back to top example" class="back-to-top position-static">
  <a href="#top" class="back-to-top-link position-static btn btn-secondary px-3">Back to top</a>
</nav>

It implies some deprecated Sass and CSS variables mentioned into the migration guide.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit bf6c450
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/653a58c76ce69c0008d9f775
😎 Deploy Preview https://deploy-preview-2340--boosted.netlify.app/docs/5.3/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond

This comment was marked as outdated.

@julien-deramond julien-deramond force-pushed the main-jd-new-back-to-top-sass-variable branch from 765a94b to b37e35d Compare October 26, 2023 09:03
@julien-deramond julien-deramond marked this pull request as ready for review October 26, 2023 09:05
@julien-deramond julien-deramond changed the title feat(back to top): new $back-to-top-icon-margin-left Sass var fix(back to top): drop useless CSS rule Oct 26, 2023
@julien-deramond
Copy link
Member Author

julien-deramond commented Oct 26, 2023

FYI I removed "Even if the rendering could still work, it is recommended to only use the versions presented in the documentation." from the migration guide since it's not true anymore and it's rather impossible to test (and we're going to forget it).

@julien-deramond julien-deramond merged commit b53b87e into main Oct 26, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-jd-new-back-to-top-sass-variable branch October 26, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants