Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie consent panel checkboxes don't reflect the state of approbation #831

Closed
3 tasks done
julien-deramond opened this issue Oct 4, 2021 · 2 comments · Fixed by #856
Closed
3 tasks done

Cookie consent panel checkboxes don't reflect the state of approbation #831

julien-deramond opened this issue Oct 4, 2021 · 2 comments · Fixed by #856
Assignees
@MewenLeHo
Labels
bug v5

Comments

@julien-deramond
Copy link
Member

Prerequisites

Describe the issue

In the cookie consent panel, clicking on buttons to accept or deny all cookies, the state is not reflected in the checkbox

2021-10-04 13 37 17

Reduced test cases

Go to https://boosted.orange.com/ in incognito mode.

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome

What version of Boosted are you using?

v5.1.1
@MewenLeHo
Copy link
Contributor

@julien-deramond : I made a CodePen for a potential solution : https://codepen.io/MewenLeHo/pen/ZEJGoZg

@julien-deramond
Copy link
Member Author

@julien-deramond : I made a CodePen for a potential solution : https://codepen.io/MewenLeHo/pen/ZEJGoZg

Thx @MewenLeHo. You can create a PR to fix this issue.

@MewenLeHo MewenLeHo self-assigned this Oct 18, 2021
MewenLeHo pushed a commit that referenced this issue Oct 18, 2021
fix(#831): checkboxes display when user accept or deny cookies
e278a8e
MewenLeHo pushed a commit that referenced this issue Oct 18, 2021
fix(#831): checkboxes display when user accept or deny cookies
e9c7f25
@julien-deramond julien-deramond linked a pull request Oct 18, 2021 that will close this issue
fix(#831): checkboxes display when user accept or deny cookies #856
Merged
MewenLeHo added a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
2d38909
MewenLeHo added a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
0735920
MewenLeHo added a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
7854fb5
MewenLeHo added a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
565e87d
MewenLeHo pushed a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
a8ba5ec
MewenLeHo pushed a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
aa5ddac
MewenLeHo added a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
5fab056
MewenLeHo added a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
54f50d7
MewenLeHo added a commit that referenced this issue Oct 18, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
363808f
MewenLeHo added a commit that referenced this issue Oct 19, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
e7fb973
MewenLeHo added a commit that referenced this issue Oct 19, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
15931a4
MewenLeHo added a commit that referenced this issue Oct 19, 2021
@MewenLeHo
fix(#831): fix everything broken after pull
f866692
MewenLeHo pushed a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
845f0b7
MewenLeHo pushed a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
710fa6d
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
100cb57
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
e3abb63
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
ed344f5
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
03e3b7f
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
0119ac6
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): fix everything broken after pull
a6d4383
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
f4efdfb
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
5eb940a
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
6879ddf
MewenLeHo added a commit that referenced this issue Oct 20, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
0fcad81
@julien-deramond julien-deramond mentioned this issue Oct 28, 2021
Merged
MewenLeHo pushed a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
f4ae90c
MewenLeHo pushed a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
8b4a713
MewenLeHo added a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
e801692
MewenLeHo added a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
03f15f4
MewenLeHo added a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
d64f328
MewenLeHo added a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
7ddd28b
MewenLeHo added a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
203b044
MewenLeHo added a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies
0356597
julien-deramond pushed a commit that referenced this issue Oct 28, 2021
@MewenLeHo
fix(#831): checkboxes display when user accept or deny cookies (#856)
18fb2da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MewenLeHo MewenLeHo

Labels
bug v5
Projects
None yet
Milestone
No milestone
2 participants
@julien-deramond @MewenLeHo