-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accordion): Remove active text color on focus #1087
fix(accordion): Remove active text color on focus #1087
Conversation
Thanks for the PR @razyon! In the current version of Boosted, the focus has the same color than the hover state for the accordions. We have this same behavior in the header for example: when a new menu item is focused the text is displayed in orange as well even if it is not yet active. However from what I see in the DSM we should have this orange color only when it its pressed and/or expanded. Let me just check with the designers to clarify some points about the different hover and pressed states. |
Checked with the designers:
This PR is good to merged. Thx for your contribution. |
author LE DIOURON Kevin <[email protected]> 1626946275 +0200 committer LE DIOURON Kevin <[email protected]> 1644573012 +0100 parent c27e1e1 author LE DIOURON Kevin <[email protected]> 1626946275 +0200 committer LE DIOURON Kevin <[email protected]> 1644572436 +0100 feat(navbars): add Global Headers components chore(review): fix bad URLs, JS formatting and SCSS errors chore(review): remove .global class reference in migration page fix(misc): WIP reviews from Louis-Maxime fix(misc): WIP reviews from Louis-Maxime fix(logo): correct scss for imgs & svgs fix(headers): align on the bottom of the text Fix(Examples) : in large viewport, orange bar below active item located to high + extra border in Exampes/NavBar (OBS) Signed-off-by: Isabelle Chanclou <[email protected]> Fix(Examples) : in small viewport, orange bar below active item located to high Signed-off-by: Isabelle Chanclou <[email protected]> Fix(global header) : add collapse for viewport 768-1023px Signed-off-by: Isabelle Chanclou <[email protected]> fix(navbar): spacing between last-child fix(minimized): [wip] spacing between icons, remove important later fix(style): [wip] clean navbar css review: add navbar static and fixed examples fix(scss) : [WIP] clean css fix(scss): [WIP] clean orange-navbar fix(scss): change comment to disable important check Fix(orange-navbar): height of global header and all its variants have a correct height in small and larger breakpoints Signed-off-by: Isabelle Chanclou <[email protected]> Fix(orange-navbar): height of global header and all its variants have a correct height in small and larger breakpoints Signed-off-by: Isabelle Chanclou <[email protected]> fix(html): Revamp of the html for examples. Some checks to do (height of elements, ...) fix(html): shortcode template for orange-navbar examples fix(menus): Ellipsis for when a text is wider than 8rem Fix for responsive part to fit to others atm Amend the large viewport container misalignment Sticky header example (#1089) * Add(Examples): add a sticky global header + supra bar example Signed-off-by: Isabelle Chanclou <[email protected]> * fix(misc): Shenanigans to fix css-side * Backport some changes * Minor fixes * fix(fixed): Have the supra + global properly fixed and sticky at the top. Todo : top 40px (into rem) Co-authored-by: Isabelle Chanclou <[email protected]> Co-authored-by: LE DIOURON Kevin <[email protected]> fix(sticky): Allocate some height to display both supra + global navbars with stickiness fix(nav-link): Show anew the active selector fix(nav-link): revert to the "original" padding as in the main branch Can't even remember why the padding in line 203 has been changed... Icons spacing + icons alignment fix(supra): Change the padding-bottom variable to fix the missing pixel Revert navbar-fixed and navbar-static examples fix(sticky): Fix the example to have both navbars into the header markup Add fake navbar-sticky images to fix 'npm run docs' Minimized fixed + burger Fix example fix(sticky): remove grey container and banner role fix(overflow): Revert the overflowing of content since it doesn't suit us atm Small changes in md- breakpoints fix(breakpoint): menu for doc navbar compatible with md breakpoint md breakpoint . Minor fix on supra + .active fix(docs): Use shortcodes for examples, add a condition to hide basket icon. TODO (or not ?): fix wrapping in docs Minor fixes chore(merge main) patched commit → c1222d6 (#1063) feat(spinners): reintegrate growing spinners from v4 (#1041) Signed-off-by: louismaximepiton <[email protected]> Co-authored-by: Julien Déramond <[email protected]> chore(dev-deps): drop `delay-cli` and add `sirv-cli` (#1005) chore(merge main) patched commit → 76802e2 (#1071) fix(#1072): vertically align labels for switches (#1081) fix(forms): black outline for focused switches (#1082) chore(merge main) patched commit → dc09509 (#1080) fix(accordion): remove active text color on focus (#1087) chore(merge main) patched commit → a805330 (#1090) chore(merge main) patched commit → 8f11c52 (#1092)
Orange Design System does not requires a font color change on focus for the accordion. We find it a bit confusing with the over state.